Changeset e5a015b in mainline for kernel/generic/src/mm/backend_anon.c

Timestamp:

2011-04-16T20:45:36Z (13 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a7dbd49

Parents:

b2fb47f (diff), 9e953bda (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge the memory reservation feature (Phase 1) from
lp:~jakub/helenos/mm.

This merge makes the testcase from ticket #114 non-reproducible. The
testcase is now available as tester's malloc2 test. It also seems to me
that this merge makes it harder for the system to run out of memory
during kconsole 'test *' and 'tester *', even though I did see several
hangs already with this feature in place. See below for what is still
missing to make the hangs even less probable or even impossible.

In Phase 1, I am targeting just the low-hanging fruits. In particular,
only anonymous and ELF backend pages are reserved physical memory at
time of as_area_create() and as_area_resize(). Memory is unreserved on
as_area_destroy(). In all other cases, memory is reserved at the same
time as it is allocated, making those calls subject to infinite
blocking if FRAME_ATOMIC is not used.

Possible sources of memory overcommit not addressed in this merge:

• As mentioned above, only backend pages are reserved; pages for supporting structures such as B+tree nodes, TTEs are not reserved or handled otherwise. Kernel heap allocator fragmentation is not included in the reservations either.
• The initial amount of reservable memory is fed from zone_construct(). Zone merging is not taken into account, which can make the reservable memory tracking inaccurate.

File:

• kernel/generic/src/mm/backend_anon.c (modified) (5 diffs)

kernel/generic/src/mm/backend_anon.c

@@ -39 +39 @@
 #include <mm/as.h>
 #include <mm/page.h>
+#include <mm/reserve.h>
 #include <genarch/mm/page_pt.h>
 #include <genarch/mm/page_ht.h>
@@ -51 +52 @@
 #include <arch.h>
 
-#ifdef CONFIG_VIRT_IDX_DCACHE
-#include <arch/mm/cache.h>
-#endif
+static bool anon_create(as_area_t *);
+static bool anon_resize(as_area_t *, size_t);
+static void anon_share(as_area_t *);
+static void anon_destroy(as_area_t *);
 
 static int anon_page_fault(as_area_t *area, uintptr_t addr, pf_access_t access);
 static void anon_frame_free(as_area_t *area, uintptr_t page, uintptr_t frame);
-static void anon_share(as_area_t *area);
 
 mem_backend_t anon_backend = {
+        .create = anon_create,
+        .resize = anon_resize,
+        .share = anon_share,
+        .destroy = anon_destroy,
+
         .page_fault = anon_page_fault,
         .frame_free = anon_frame_free,
-        .share = anon_share
 };
+
+bool anon_create(as_area_t *area)
+{
+        return reserve_try_alloc(area->pages);
+}
+
+bool anon_resize(as_area_t *area, size_t new_pages)
+{
+        if (new_pages > area->pages)
+                return reserve_try_alloc(new_pages - area->pages);
+        else if (new_pages < area->pages)
+                reserve_free(area->pages - new_pages);
+
+        return true;
+}
+
+/** Share the anonymous address space area.
+ *
+ * Sharing of anonymous area is done by duplicating its entire mapping
+ * to the pagemap. Page faults will primarily search for frames there.
+ *
+ * The address space and address space area must be already locked.
+ *
+ * @param area Address space area to be shared.
+ */
+void anon_share(as_area_t *area)
+{
+        link_t *cur;
+
+        ASSERT(mutex_locked(&area->as->lock));
+        ASSERT(mutex_locked(&area->lock));
+
+        /*
+         * Copy used portions of the area to sh_info's page map.
+         */
+        mutex_lock(&area->sh_info->lock);
+        for (cur = area->used_space.leaf_head.next;
+            cur != &area->used_space.leaf_head; cur = cur->next) {
+                btree_node_t *node;
+                unsigned int i;
+                
+                node = list_get_instance(cur, btree_node_t, leaf_link);
+                for (i = 0; i < node->keys; i++) {
+                        uintptr_t base = node->key[i];
+                        size_t count = (size_t) node->value[i];
+                        unsigned int j;
+                        
+                        for (j = 0; j < count; j++) {
+                                pte_t *pte;
+                        
+                                page_table_lock(area->as, false);
+                                pte = page_mapping_find(area->as,
+                                    base + j * PAGE_SIZE);
+                                ASSERT(pte && PTE_VALID(pte) &&
+                                    PTE_PRESENT(pte));
+                                btree_insert(&area->sh_info->pagemap,
+                                    (base + j * PAGE_SIZE) - area->base,
+                                    (void *) PTE_GET_FRAME(pte), NULL);
+                                page_table_unlock(area->as, false);
+
+                                pfn_t pfn = ADDR2PFN(PTE_GET_FRAME(pte));
+                                frame_reference_add(pfn);
+                        }
+
+                }
+        }
+        mutex_unlock(&area->sh_info->lock);
+}
+
+void anon_destroy(as_area_t *area)
+{
+        reserve_free(area->pages);
+}
+
 
 /** Service a page fault in the anonymous memory address space area.
@@ -115 +194 @@
                         }
                         if (allocate) {
-                                frame = (uintptr_t) frame_alloc(ONE_FRAME, 0);
+                                frame = (uintptr_t) frame_alloc_noreserve(
+                                    ONE_FRAME, 0);
                                 memsetb((void *) PA2KA(frame), FRAME_SIZE, 0);
                                 
@@ -145 +225 @@
                  *   the different causes
                  */
-                frame = (uintptr_t) frame_alloc(ONE_FRAME, 0);
+                frame = (uintptr_t) frame_alloc_noreserve(ONE_FRAME, 0);
                 memsetb((void *) PA2KA(frame), FRAME_SIZE, 0);
         }
@@ -174 +254 @@
         ASSERT(mutex_locked(&area->lock));
 
-        frame_free(frame);
-}
-
-/** Share the anonymous address space area.
- *
- * Sharing of anonymous area is done by duplicating its entire mapping
- * to the pagemap. Page faults will primarily search for frames there.
- *
- * The address space and address space area must be already locked.
- *
- * @param area Address space area to be shared.
- */
-void anon_share(as_area_t *area)
-{
-        link_t *cur;
-
-        ASSERT(mutex_locked(&area->as->lock));
-        ASSERT(mutex_locked(&area->lock));
-
-        /*
-         * Copy used portions of the area to sh_info's page map.
-         */
-        mutex_lock(&area->sh_info->lock);
-        for (cur = area->used_space.leaf_head.next;
-            cur != &area->used_space.leaf_head; cur = cur->next) {
-                btree_node_t *node;
-                unsigned int i;
-                
-                node = list_get_instance(cur, btree_node_t, leaf_link);
-                for (i = 0; i < node->keys; i++) {
-                        uintptr_t base = node->key[i];
-                        size_t count = (size_t) node->value[i];
-                        unsigned int j;
-                        
-                        for (j = 0; j < count; j++) {
-                                pte_t *pte;
-                        
-                                page_table_lock(area->as, false);
-                                pte = page_mapping_find(area->as,
-                                    base + j * PAGE_SIZE);
-                                ASSERT(pte && PTE_VALID(pte) &&
-                                    PTE_PRESENT(pte));
-                                btree_insert(&area->sh_info->pagemap,
-                                    (base + j * PAGE_SIZE) - area->base,
-                                    (void *) PTE_GET_FRAME(pte), NULL);
-                                page_table_unlock(area->as, false);
-
-                                pfn_t pfn = ADDR2PFN(PTE_GET_FRAME(pte));
-                                frame_reference_add(pfn);
-                        }
-
-                }
-        }
-        mutex_unlock(&area->sh_info->lock);
+        frame_free_noreserve(frame);
 }