Changeset ddfd158 in mainline for kernel/arch/mips32/src/mm/tlb.c

Timestamp:

2013-03-16T22:49:33Z (11 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

89f61be

Parents:

b696cbf

Message:

Instead of asserting on the failure to find the faulting entry
in the TLB, print a warning to make life with buggy emulators easier.

File:

• kernel/arch/mips32/src/mm/tlb.c (modified) (2 diffs)

kernel/arch/mips32/src/mm/tlb.c

@@ -197 +197 @@
         pte_t *pte;
 
+        badvaddr = cp0_badvaddr_read();
+
         /*
          * Locate the faulting entry in TLB.
@@ -204 +206 @@
 
         /*
-         * Fail if the entry is not in TLB.
+         * Emit warning if the entry is not in TLB.
+         *
+         * We do not assert on this because this could be a manifestation of
+         * an emulator bug, such as QEMU Bug #1128935:
+         * https://bugs.launchpad.net/qemu/+bug/1128935  
          */
-        ASSERT(!index.p);
-
-        badvaddr = cp0_badvaddr_read();
+        if (index.p) {
+                printf("%s: TLBP failed in exception handler (badvaddr=%#"
+                    PRIxn ", ASID=%d).\n", __func__, badvaddr,
+                    AS ? AS->asid : -1);
+                return;
+        }
 
         pte = page_mapping_find(AS, badvaddr, true);