Changeset ddd0499d in mainline for uspace/drv/bus/usb/uhcirh/main.c

Timestamp:

2013-09-12T22:05:13Z (11 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4285851

Parents:

695b6ff (diff), 7de1988c (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Support for PIO window-relative and absolute HW resource ranges.

The goal of this merge is to allow bus drivers to pass resources with IO
and memory ranges to the child drivers either in the PIO window-relative
form or system bus absolute form. Using the PIO window and the
relative/absolute attribute of a range, each driver can now reconstruct
both forms. Helper functions are provided to automate these
transformations as much as possible.

Changes in this merge in a greater detail:

• Support for PIO_WINDOW_DEV_IFACE in isa so that it can provide the PIO window to its children.

• Add 'relative' member to both hw_resource_t.res.mem_range and hw_resource_t.res.io_range so that the drivers can actually tell whether a range is absolute (eg. it was absolutized by its parent).

• Add pio_enable_resource() to allow drivers to enable PIO without the need to actually care about what kind of range the resource contains. This is used by pci now.

• Automate things even more for drivers that use hw_res_get_list_parsed(). The parsed HW resources compute both forms (relative/absolute) and offer it to the driver which is using them. Such a driver then uses whatever form is more fit for it and its purposes.

• Drivers using the parsed resources can use pio_enable_range() to enable PIO and RNGABS*()/RNGREL()/RNGSZ courtesy macros for easier access to the actual range address/size are provided.

• Device drivers affected by these API changes were converted.

• uhcirh now requires uhci to provide PIO_WINDOW_DEV_IFACE; however, the uhcirh driver is removed in the feature USB branch so there was no point in implementing this feature and UHCI USB is thus temporarily broken.

File:

• uspace/drv/bus/usb/uhcirh/main.c (modified) (6 diffs)

uspace/drv/bus/usb/uhcirh/main.c

@@ -48 +48 @@
 #define NAME "uhcirh"
 
-static int hc_get_my_registers(ddf_dev_t *dev,
-    uintptr_t *io_reg_address, size_t *io_reg_size);
+static int hc_get_my_registers(ddf_dev_t *dev, addr_range_t *io_regs);
 
 static int uhci_rh_dev_add(ddf_dev_t *device);
@@ -90 +89 @@
             ddf_dev_get_handle(device));
 
-        uintptr_t io_regs = 0;
-        size_t io_size = 0;
+        addr_range_t regs;
         uhci_root_hub_t *rh = NULL;
         int rc;
 
-        rc = hc_get_my_registers(device, &io_regs, &io_size);
+        rc = hc_get_my_registers(device, &regs);
         if (rc != EOK) {
                 usb_log_error( "Failed to get registers from HC: %s.\n",
@@ -103 +101 @@
 
         usb_log_debug("I/O regs at %p (size %zuB).\n",
-            (void *) io_regs, io_size);
+            RNGABSPTR(regs), RNGSZ(regs));
 
         rh = ddf_dev_data_alloc(device, sizeof(uhci_root_hub_t));
@@ -111 +109 @@
         }
 
-        rc = uhci_root_hub_init(rh, (void*)io_regs, io_size, device);
+        rc = uhci_root_hub_init(rh, &regs, device);
         if (rc != EOK) {
                 usb_log_error("Failed(%d) to initialize rh driver instance: "
@@ -127 +125 @@
  *
  * @param[in] dev Device asking for the addresses.
- * @param[out] io_reg_address Base address of the memory range.
- * @param[out] io_reg_size Size of the memory range.
+ * @param[out] io_regs_p Pointer to the device's register range.
  * @return Error code.
  */
-int hc_get_my_registers(
-    ddf_dev_t *dev, uintptr_t *io_reg_address, size_t *io_reg_size)
+int hc_get_my_registers(ddf_dev_t *dev, addr_range_t *io_regs_p)
 {
         async_sess_t *parent_sess =
@@ -153 +149 @@
         }
 
-        if (io_reg_address != NULL)
-                *io_reg_address = hw_res.io_ranges.ranges[0].address;
-
-        if (io_reg_size != NULL)
-                *io_reg_size = hw_res.io_ranges.ranges[0].size;
+        if (io_regs_p != NULL)
+                *io_regs_p = hw_res.io_ranges.ranges[0];
 
         hw_res_list_parsed_clean(&hw_res);