Changeset dd7078c in mainline

Timestamp:

2013-09-01T16:16:17Z (11 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

3f03199

Parents:

26e2de3

Message:

ohci: Add additional checks and a TODO

File:

• uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.c (modified) (3 diffs)

uspace/drv/bus/usb/ohci/hw_struct/endpoint_descriptor.c

@@ -33 +33 @@
  */
 #include "endpoint_descriptor.h"
+#include "macros.h"
 
 /** USB direction to OHCI values translation table. */
@@ -61 +62 @@
                 return;
         }
-        /* Non-dummy ED must have TD assigned */
+        /* Non-dummy ED must have corresponding EP and TD assigned */
         assert(td);
+        assert(ep);
+        assert(ep->direction < ARRAY_SIZE(dir));
 
         /* Status: address, endpoint nr, direction mask and max packet size. */
@@ -77 +80 @@
 
         /* Isochronous format flag */
+        // TODO: We need iTD instead of TD for iso transfers
         if (ep->transfer_type == USB_TRANSFER_ISOCHRONOUS)
                 OHCI_MEM32_SET(instance->status, ED_STATUS_F_FLAG);