Changeset dc12262 in mainline for uspace/lib/c/generic/io/printf_core.c

Timestamp:

2017-05-04T22:12:27Z (7 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e141281

Parents:

93ad8166

Message:

add standardized case fallthrough comment annotations, add actual missing breaks

GCC 7.1's attribute((fallthrough)) would be more elegant, but unfortunatelly this annotation is incompatible with previous versions of GCC (it generates an empty declaration error)

File:

• uspace/lib/c/generic/io/printf_core.c (modified) (5 diffs)

uspace/lib/c/generic/io/printf_core.c

@@ -1217 +1217 @@
         case 'F':
                 flags |= __PRINTF_FLAG_BIGCHARS;
-                /* Fall through.*/
+                /* Fallthrough */
         case 'f':
                 precision = (precision < 0) ? 6 : precision;
@@ -1224 +1224 @@
         case 'E':
                 flags |= __PRINTF_FLAG_BIGCHARS;
-                /* Fall through.*/
+                /* Fallthrough */
         case 'e':
                 precision = (precision < 0) ? 6 : precision;
@@ -1231 +1231 @@
         case 'G':
                 flags |= __PRINTF_FLAG_BIGCHARS;
-                /* Fall through.*/
+                /* Fallthrough */
         case 'g':
                 return print_double_generic(g, precision, width, flags, ps);
@@ -1553 +1553 @@
                                 /* Pointer */
                                 flags |= __PRINTF_FLAG_BIGCHARS;
+                                /* Fallthrough */
                         case 'p':
                                 flags |= __PRINTF_FLAG_PREFIX;
@@ -1568 +1569 @@
                         case 'i':
                                 flags |= __PRINTF_FLAG_SIGNED;
+                                /* Fallthrough */
                         case 'u':
                                 break;
                         case 'X':
                                 flags |= __PRINTF_FLAG_BIGCHARS;
+                                /* Fallthrough */
                         case 'x':
                                 base = 16;