Changeset da1bafb in mainline for kernel/generic/src/main/kinit.c

Timestamp:

2010-05-24T18:57:31Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/generic/src/main/kinit.c (modified) (5 diffs)

kernel/generic/src/main/kinit.c

@@ -115 +115 @@
                 thread = thread_create(kmp, NULL, TASK, THREAD_FLAG_WIRED, "kmp", true);
                 if (thread != NULL) {
-                        spinlock_lock(&thread->lock);
+                        irq_spinlock_lock(&thread->lock, false);
                         thread->cpu = &cpus[0];
-                        spinlock_unlock(&thread->lock);
+                        irq_spinlock_unlock(&thread->lock, false);
                         thread_ready(thread);
                 } else
@@ -135 +135 @@
                         thread = thread_create(kcpulb, NULL, TASK, THREAD_FLAG_WIRED, "kcpulb", true);
                         if (thread != NULL) {
-                                spinlock_lock(&thread->lock);
+                                irq_spinlock_lock(&thread->lock, false);
                                 thread->cpu = &cpus[i];
-                                spinlock_unlock(&thread->lock);
+                                irq_spinlock_unlock(&thread->lock, false);
                                 thread_ready(thread);
                         } else
@@ -199 +199 @@
                 str_cpy(namebuf + INIT_PREFIX_LEN,
                     TASK_NAME_BUFLEN - INIT_PREFIX_LEN, name);
-
+                
                 int rc = program_create_from_image((void *) init.tasks[i].addr,
                     namebuf, &programs[i]);
@@ -222 +222 @@
                 }
         }
-
+        
         /*
          * Run user tasks.
@@ -230 +230 @@
                         program_ready(&programs[i]);
         }
-
+        
 #ifdef CONFIG_KCONSOLE
         if (!stdin) {