Changeset da1bafb in mainline for kernel/generic/src/ddi/ddi.c

Timestamp:

2010-05-24T18:57:31Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/generic/src/ddi/ddi.c (modified) (8 diffs)

kernel/generic/src/ddi/ddi.c

@@ -59 +59 @@
 static btree_t parea_btree;
 
-/** Initialize DDI. */
+/** Initialize DDI.
+ *
+ */
 void ddi_init(void)
 {
@@ -97 +99 @@
  *
  */
-static int ddi_physmem_map(uintptr_t pf, uintptr_t vp, size_t pages, int flags)
+static int ddi_physmem_map(uintptr_t pf, uintptr_t vp, size_t pages,
+    unsigned int flags)
 {
         ASSERT(TASK);
@@ -114 +117 @@
         backend_data.frames = pages;
         
-        ipl_t ipl = interrupts_disable();
-        
         /* Find the zone of the physical memory */
-        spinlock_lock(&zones.lock);
+        irq_spinlock_lock(&zones.lock, true);
         size_t znum = find_zone(ADDR2PFN(pf), pages, 0);
         
@@ -124 +125 @@
                  * -> assume it is hardware device and allow mapping
                  */
-                spinlock_unlock(&zones.lock);
+                irq_spinlock_unlock(&zones.lock, true);
                 goto map;
         }
@@ -130 +131 @@
         if (zones.info[znum].flags & ZONE_FIRMWARE) {
                 /* Frames are part of firmware */
-                spinlock_unlock(&zones.lock);
+                irq_spinlock_unlock(&zones.lock, true);
                 goto map;
         }
         
         if (zone_flags_available(zones.info[znum].flags)) {
-                /* Frames are part of physical memory, check if the memory
+                /*
+                 * Frames are part of physical memory, check if the memory
                  * region is enabled for mapping.
                  */
-                spinlock_unlock(&zones.lock);
+                irq_spinlock_unlock(&zones.lock, true);
                 
                 mutex_lock(&parea_lock);
@@ -154 +156 @@
         }
         
-        spinlock_unlock(&zones.lock);
+        irq_spinlock_unlock(&zones.lock, true);
+        
 err:
-        interrupts_restore(ipl);
         return ENOENT;
         
 map:
-        interrupts_restore(ipl);
-
         if (!as_area_create(TASK->as, flags, pages * PAGE_SIZE, vp,
             AS_AREA_ATTR_NONE, &phys_backend, &backend_data)) {
@@ -196 +196 @@
                 return EPERM;
         
-        ipl_t ipl = interrupts_disable();
-        spinlock_lock(&tasks_lock);
+        irq_spinlock_lock(&tasks_lock, true);
         
         task_t *task = task_find_by_id(id);
@@ -207 +206 @@
                  * context.
                  */
-                spinlock_unlock(&tasks_lock);
-                interrupts_restore(ipl);
+                irq_spinlock_unlock(&tasks_lock, true);
                 return ENOENT;
         }
         
         /* Lock the task and release the lock protecting tasks_btree. */
-        spinlock_lock(&task->lock);
-        spinlock_unlock(&tasks_lock);
+        irq_spinlock_exchange(&tasks_lock, &task->lock);
         
         int rc = ddi_iospace_enable_arch(task, ioaddr, size);
         
-        spinlock_unlock(&task->lock);
-        interrupts_restore(ipl);
+        irq_spinlock_unlock(&task->lock, true);
         
         return rc;