Changeset da1bafb in mainline for kernel/genarch/src/mm/as_pt.c

Timestamp:

2010-05-24T18:57:31Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/genarch/src/mm/as_pt.c (modified) (6 diffs)

kernel/genarch/src/mm/as_pt.c

@@ -33 +33 @@
 /**
  * @file
- * @brief       Address space functions for 4-level hierarchical pagetables.
+ * @brief Address space functions for 4-level hierarchical pagetables.
  */
 
@@ -47 +47 @@
 #include <arch.h>
 
-static pte_t *ptl0_create(int flags);
-static void ptl0_destroy(pte_t *page_table);
+static pte_t *ptl0_create(unsigned int);
+static void ptl0_destroy(pte_t *);
 
-static void pt_lock(as_t *as, bool lock);
-static void pt_unlock(as_t *as, bool unlock);
+static void pt_lock(as_t *, bool);
+static void pt_unlock(as_t *, bool);
 
 as_operations_t as_pt_operations = {
@@ -67 +67 @@
  *
  * @return New PTL0.
+ *
  */
-pte_t *ptl0_create(int flags)
+pte_t *ptl0_create(unsigned int flags)
 {
-        pte_t *src_ptl0, *dst_ptl0;
-        ipl_t ipl;
-        int table_size;
-
-        dst_ptl0 = (pte_t *) frame_alloc(PTL0_SIZE, FRAME_KA);
-        table_size = FRAME_SIZE << PTL0_SIZE;
-
-        if (flags & FLAG_AS_KERNEL) {
+        pte_t *dst_ptl0 = (pte_t *) frame_alloc(PTL0_SIZE, FRAME_KA);
+        size_t table_size = FRAME_SIZE << PTL0_SIZE;
+        
+        if (flags & FLAG_AS_KERNEL)
                 memsetb(dst_ptl0, table_size, 0);
-        } else {
-                uintptr_t src, dst;
-        
+        else {
                 /*
                  * Copy the kernel address space portion to new PTL0.
+                 *
                  */
-                 
-                ipl = interrupts_disable();
-                mutex_lock(&AS_KERNEL->lock);           
-                src_ptl0 = (pte_t *) PA2KA((uintptr_t) AS_KERNEL->genarch.page_table);
-
-                src = (uintptr_t) &src_ptl0[PTL0_INDEX(KERNEL_ADDRESS_SPACE_START)];
-                dst = (uintptr_t) &dst_ptl0[PTL0_INDEX(KERNEL_ADDRESS_SPACE_START)];
-
+                
+                ipl_t ipl = interrupts_disable();
+                mutex_lock(&AS_KERNEL->lock);
+                
+                pte_t *src_ptl0 =
+                    (pte_t *) PA2KA((uintptr_t) AS_KERNEL->genarch.page_table);
+                
+                uintptr_t src =
+                    (uintptr_t) &src_ptl0[PTL0_INDEX(KERNEL_ADDRESS_SPACE_START)];
+                uintptr_t dst =
+                    (uintptr_t) &dst_ptl0[PTL0_INDEX(KERNEL_ADDRESS_SPACE_START)];
+                
                 memsetb(dst_ptl0, table_size, 0);
-                memcpy((void *) dst, (void *) src, table_size - (src - (uintptr_t) src_ptl0));
+                memcpy((void *) dst, (void *) src,
+                    table_size - (src - (uintptr_t) src_ptl0));
+                
                 mutex_unlock(&AS_KERNEL->lock);
                 interrupts_restore(ipl);
         }
-
+        
         return (pte_t *) KA2PA((uintptr_t) dst_ptl0);
 }
@@ -107 +109 @@
  *
  * @param page_table Physical address of PTL0.
+ *
  */
 void ptl0_destroy(pte_t *page_table)
 {
-        frame_free((uintptr_t)page_table);
+        frame_free((uintptr_t) page_table);
 }
 
@@ -118 +121 @@
  * Interrupts must be disabled.
  *
- * @param as Address space.
+ * @param as   Address space.
  * @param lock If false, do not attempt to lock the address space.
+ *
  */
 void pt_lock(as_t *as, bool lock)
@@ -132 +136 @@
  * Interrupts must be disabled.
  *
- * @param as Address space.
+ * @param as     Address space.
  * @param unlock If false, do not attempt to unlock the address space.
+ *
  */
 void pt_unlock(as_t *as, bool unlock)