Changeset da1bafb in mainline for kernel/arch/sparc64/src/trap/sun4u/interrupt.c

Timestamp:

2010-05-24T18:57:31Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/arch/sparc64/src/trap/sun4u/interrupt.c (modified) (4 diffs)

kernel/arch/sparc64/src/trap/sun4u/interrupt.c

@@ -55 +55 @@
 void interrupt(int n, istate_t *istate)
 {
-        uint64_t status;
-        uint64_t intrcv;
-        uint64_t data0;
-        status = asi_u64_read(ASI_INTR_DISPATCH_STATUS, 0);
+        uint64_t status = asi_u64_read(ASI_INTR_DISPATCH_STATUS, 0);
         if (status & (!INTR_DISPATCH_STATUS_BUSY))
                 panic("Interrupt Dispatch Status busy bit not set\n");
-
-        intrcv = asi_u64_read(ASI_INTR_RECEIVE, 0);
+        
+        uint64_t intrcv = asi_u64_read(ASI_INTR_RECEIVE, 0);
 #if defined (US)
-        data0 = asi_u64_read(ASI_INTR_R, ASI_UDB_INTR_R_DATA_0);
+        uint64_t data0 = asi_u64_read(ASI_INTR_R, ASI_UDB_INTR_R_DATA_0);
 #elif defined (US3)
-        data0 = asi_u64_read(ASI_INTR_R, VA_INTR_R_DATA_0);
+        uint64_t data0 = asi_u64_read(ASI_INTR_R, VA_INTR_R_DATA_0);
 #endif
-
+        
         irq_t *irq = irq_dispatch_and_lock(data0);
         if (irq) {
@@ -75 +72 @@
                  */
                 irq->handler(irq);
+                
                 /*
                  * See if there is a clear-interrupt-routine and call it.
                  */
-                if (irq->cir) {
+                if (irq->cir)
                         irq->cir(irq->cir_arg, irq->inr);
-                }
-                spinlock_unlock(&irq->lock);
+                
+                irq_spinlock_unlock(&irq->lock, false);
         } else if (data0 > config.base) {
                 /*
@@ -90 +88 @@
                  */
 #ifdef CONFIG_SMP
-                if (data0 == (uintptr_t) tlb_shootdown_ipi_recv) {
+                if (data0 == (uintptr_t) tlb_shootdown_ipi_recv)
                         tlb_shootdown_ipi_recv();
-                }
 #endif
         } else {
@@ -101 +98 @@
                 printf("cpu%u: spurious interrupt (intrcv=%#" PRIx64
                     ", data0=%#" PRIx64 ")\n", CPU->id, intrcv, data0);
+#else
+                (void) intrcv;
 #endif
         }
-
+        
         membar();
         asi_u64_write(ASI_INTR_RECEIVE, 0, 0);