Changeset da1bafb in mainline for kernel/arch/ia64/src/interrupt.c

Timestamp:

2010-05-24T18:57:31Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0095368

Parents:

666f492

Message:

major code revision

• replace spinlocks taken with interrupts disabled with irq_spinlocks
• change spacing (not indendation) to be tab-size independent
• use unsigned integer types where appropriate (especially bit flags)
• visual separation
• remove argument names in function prototypes
• string changes
• correct some formating directives
• replace various cryptic single-character variables (t, a, m, c, b, etc.) with proper identifiers (thread, task, timeout, as, itm, itc, etc.)
• unify some assembler constructs
• unused page table levels are now optimized out in compile time
• replace several ints (with boolean semantics) with bools
• use specifically sized types instead of generic types where appropriate (size_t, uint32_t, btree_key_t)
• improve comments
• split asserts with conjuction into multiple independent asserts

File:

• kernel/arch/ia64/src/interrupt.c (modified) (8 diffs)

kernel/arch/ia64/src/interrupt.c

@@ -57 +57 @@
 #include <putchar.h>
 
-#define VECTORS_64_BUNDLE       20
-#define VECTORS_16_BUNDLE       48
-#define VECTORS_16_BUNDLE_START 0x5000
-#define VECTOR_MAX              0x7f00
-
-#define BUNDLE_SIZE             16
+#define VECTORS_64_BUNDLE        20
+#define VECTORS_16_BUNDLE        48
+#define VECTORS_16_BUNDLE_START  0x5000
+
+#define VECTOR_MAX  0x7f00
+
+#define BUNDLE_SIZE  16
 
 static const char *vector_names_64_bundle[VECTORS_64_BUNDLE] = {
@@ -134 +135 @@
 static void dump_interrupted_context(istate_t *istate)
 {
-        const char *ifa = symtab_fmt_name_lookup(istate->cr_ifa);
-        const char *iipa = symtab_fmt_name_lookup(istate->cr_iipa);
-        const char *iip = symtab_fmt_name_lookup(istate->cr_iip);
-        
         putchar('\n');
         printf("Interrupted context dump:\n");
@@ -149 +146 @@
             istate->cr_ipsr);
         
-        printf("cr.iip=%#018llx, #%d\t(%s)\n", istate->cr_iip,
-            istate->cr_isr.ei, iip);
-        printf("cr.iipa=%#018llx\t(%s)\n", istate->cr_iipa, iipa);
-        printf("cr.ifa=%#018llx\t(%s)\n", istate->cr_ifa, ifa);
+        printf("cr.iip=%#018llx, #%d\t(%s)\n", istate->cr_iip, istate->cr_isr.ei,
+            symtab_fmt_name_lookup(istate->cr_iip));
+        printf("cr.iipa=%#018llx\t(%s)\n", istate->cr_iipa,
+            symtab_fmt_name_lookup(istate->cr_iipa));
+        printf("cr.ifa=%#018llx\t(%s)\n", istate->cr_ifa,
+            symtab_fmt_name_lookup(istate->cr_ifa));
 }
 
@@ -218 +217 @@
                 istate->cr_ipsr.ri++;
         }
-
+        
         return syscall_handler(istate->in0, istate->in1, istate->in2,
             istate->in3, istate->in4, istate->in5, istate->in6);
@@ -234 +233 @@
 static void end_of_local_irq(void)
 {
-        asm volatile ("mov cr.eoi=r0;;");
-}
-
+        asm volatile (
+                "mov cr.eoi=r0;;"
+        );
+}
 
 void external_interrupt(uint64_t vector, istate_t *istate)
 {
         cr_ivr_t ivr;
-        irq_t *irq;
         
         ivr.value = ivr_read();
         srlz_d();
-
+        
+        irq_t *irq;
+        
         switch (ivr.vector) {
         case INTERRUPT_SPURIOUS:
@@ -252 +253 @@
 #endif
                 break;
-
+        
 #ifdef CONFIG_SMP
         case VECTOR_TLB_SHOOTDOWN_IPI:
@@ -259 +260 @@
                 break;
 #endif
-
+        
         case INTERRUPT_TIMER:
                 irq = irq_dispatch_and_lock(ivr.vector);
                 if (irq) {
                         irq->handler(irq);
-                        spinlock_unlock(&irq->lock);
+                        irq_spinlock_unlock(&irq->lock, false);
                 } else {
                         panic("Unhandled Internal Timer Interrupt (%d).",
@@ -283 +284 @@
                         if (!irq->preack)
                                 end_of_local_irq();
-                        spinlock_unlock(&irq->lock);
+                        irq_spinlock_unlock(&irq->lock, false);
                 } else {
                         /*