Changeset d8b275d in mainline for uspace/drv/uhci-hcd/iface.c

Timestamp:

2011-04-14T08:24:29Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5e07e2b5

Parents:

3f2af64 (diff), 34e8bab (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge development/ changes

File:

• uspace/drv/uhci-hcd/iface.c (modified) (9 diffs)

uspace/drv/uhci-hcd/iface.c

@@ -63 +63 @@
         }
 
+        usb_log_debug("%s %d:%d %zu(%zu).\n",
+            name, target.address, target.endpoint, size, ep->max_packet_size);
+
         const size_t bw = bandwidth_count_usb11(
             ep->speed, ep->transfer_type, size, ep->max_packet_size);
@@ -68 +71 @@
                 usb_log_error("Endpoint(%d:%d) %s needs %zu bw "
                     "but only %zu is reserved.\n",
-                    name, target.address, target.endpoint, bw, res_bw);
+                    target.address, target.endpoint, name, bw, res_bw);
                 return ENOSPC;
         }
-        usb_log_debug("%s %d:%d %zu(%zu).\n",
-            name, target.address, target.endpoint, size, ep->max_packet_size);
 
         *batch = batch_get(
@@ -146 +147 @@
         hc_t *hc = fun_to_hc(fun);
         assert(hc);
+        const size_t size = max_packet_size;
         usb_speed_t speed = usb_device_keeper_get_speed(&hc->manager, address);
         if (speed >= USB_SPEED_MAX) {
                 speed = ep_speed;
         }
-        const size_t size =
-            (transfer_type == USB_TRANSFER_INTERRUPT
-            || transfer_type == USB_TRANSFER_ISOCHRONOUS) ?
-            max_packet_size : 0;
-        int ret;
-
-        endpoint_t *ep = malloc(sizeof(endpoint_t));
-        if (ep == NULL)
-                return ENOMEM;
-        ret = endpoint_init(ep, address, endpoint, direction,
-            transfer_type, speed, max_packet_size);
-        if (ret != EOK) {
-                free(ep);
-                return ret;
-        }
-
         usb_log_debug("Register endpoint %d:%d %s %s(%d) %zu(%zu) %u.\n",
             address, endpoint, usb_str_transfer_type(transfer_type),
             usb_str_speed(speed), direction, size, max_packet_size, interval);
 
-        ret = usb_endpoint_manager_register_ep(&hc->ep_manager, ep, size);
-        if (ret != EOK) {
-                endpoint_destroy(ep);
-        }
-        return ret;
+        return usb_endpoint_manager_add_ep(&hc->ep_manager, address, endpoint,
+            direction, transfer_type, speed, max_packet_size, size);
 }
 /*----------------------------------------------------------------------------*/
@@ -212 +195 @@
         ret = hc_schedule(hc, batch);
         if (ret != EOK) {
-                batch_dispose(batch);
+                usb_transfer_batch_dispose(batch);
         }
         return ret;
@@ -240 +223 @@
         ret = hc_schedule(hc, batch);
         if (ret != EOK) {
-                batch_dispose(batch);
+                usb_transfer_batch_dispose(batch);
         }
         return ret;
@@ -268 +251 @@
         ret = hc_schedule(hc, batch);
         if (ret != EOK) {
-                batch_dispose(batch);
+                usb_transfer_batch_dispose(batch);
         }
         return ret;
@@ -296 +279 @@
         ret = hc_schedule(hc, batch);
         if (ret != EOK) {
-                batch_dispose(batch);
+                usb_transfer_batch_dispose(batch);
         }
         return ret;
@@ -329 +312 @@
         ret = hc_schedule(hc, batch);
         if (ret != EOK) {
-                batch_dispose(batch);
+                usb_transfer_batch_dispose(batch);
         }
         return ret;
@@ -361 +344 @@
         ret = hc_schedule(hc, batch);
         if (ret != EOK) {
-                batch_dispose(batch);
+                usb_transfer_batch_dispose(batch);
         }
         return ret;