Changeset d0c2beb in mainline for kernel/generic/include/ipc/sysipc_ops.h

Timestamp:

2017-12-19T17:38:18Z (6 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

219c530

Parents:

89ea2dc

Message:

Make SYSIPC_OP work regardless of the return type.

Currently, the macro assumes that the result is an error code, which
is not true for request_process. The if (ops->op) is turned to an
assert, because there's always at least a null_xxx stub assigned.
Null pointer should never occur in any of those fields.

File:

• kernel/generic/include/ipc/sysipc_ops.h (modified) (1 diff)

kernel/generic/include/ipc/sysipc_ops.h

@@ -40 +40 @@
 #define SYSIPC_OP(op, call, ...) \
         ({ \
-                int rc = EOK; \
-                \
-                sysipc_ops_t *ops; \
-                ops = sysipc_ops_get((call)->request_method); \
-                if (ops->op) \
-                        rc = ops->op((call), ##__VA_ARGS__); \
-                rc; \
+                sysipc_ops_t *ops = sysipc_ops_get((call)->request_method); \
+                assert(ops->op); \
+                ops->op((call), ##__VA_ARGS__); \
         })