Changeset cd3b380 in mainline for kernel/generic/src/cpu/cpu.c

Timestamp:

2013-09-11T11:56:39Z (11 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1db5669

Parents:

43dd8028

Message:

due to the removal of FRAME_KA, the return value of frame_alloc*() needs to be checked before converting the physical address to kernel address

File:

• kernel/generic/src/cpu/cpu.c (modified) (1 diff)

kernel/generic/src/cpu/cpu.c

@@ -73 +73 @@
                 size_t i;
                 for (i = 0; i < config.cpu_count; i++) {
-                        cpus[i].stack = (uint8_t *) PA2KA(frame_alloc(STACK_FRAMES,
-                            FRAME_LOWMEM | FRAME_ATOMIC, STACK_SIZE - 1));
+                        uintptr_t stack_phys = frame_alloc(STACK_FRAMES,
+                            FRAME_LOWMEM | FRAME_ATOMIC, STACK_SIZE - 1);
+                        if (!stack_phys)
+                                panic("Cannot allocate CPU stack.");
+                        
+                        cpus[i].stack = (uint8_t *) PA2KA(stack_phys);
                         cpus[i].id = i;
                         
                         irq_spinlock_initialize(&cpus[i].lock, "cpus[].lock");
                         
-                        unsigned int j;
-                        for (j = 0; j < RQ_COUNT; j++) {
+                        for (unsigned int j = 0; j < RQ_COUNT; j++) {
                                 irq_spinlock_initialize(&cpus[i].rq[j].lock, "cpus[].rq[].lock");
                                 list_initialize(&cpus[i].rq[j].rq);