Changeset cb63854 in mainline

Timestamp:

2018-01-20T20:52:00Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

58f4c0f

Parents:

4397984

Message:

usbhub: fix hub depth off-by-one

File:

• uspace/drv/bus/usb/usbhub/usbhub.c (modified) (2 diffs)

uspace/drv/bus/usb/usbhub/usbhub.c

@@ -338 +338 @@
         hub_dev->control_pipe = control_pipe;
 
+        usb_log_debug("(%p): Setting hub depth to %u.", hub_dev,
+            usb_device_get_depth(hub_dev->usb_device));
         if ((opResult = usb_hub_set_depth(hub_dev))) {
                 usb_log_error("(%p): Failed to set hub depth: %s.",
@@ -486 +488 @@
                 .request_type = USB_HUB_REQ_TYPE_SET_HUB_DEPTH,
                 .request = USB_HUB_REQUEST_SET_HUB_DEPTH,
-                .value = uint16_host2usb(usb_device_get_depth(hub->usb_device)),
+                .value = uint16_host2usb(usb_device_get_depth(hub->usb_device) - 1),
                 .index = 0,
                 .length = 0,