Changeset c828803 in mainline for uspace/lib/c/generic/malloc.c

Timestamp:

2012-07-24T10:04:01Z (12 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f66c203d

Parents:

da287d1

Message:

add comment describing the motivation for the alignment

File:

• uspace/lib/c/generic/malloc.c (modified) (3 diffs)

uspace/lib/c/generic/malloc.c

@@ -720 +720 @@
                 return NULL;
         
+        /*
+         * The size of the allocated block needs to be naturally
+         * aligned, because the footer structure also needs to reside
+         * on a naturally aligned address in order to avoid unaligned
+         * memory accesses.
+         */
         size_t gross_size = GROSS_SIZE(ALIGN_UP(size, BASE_ALIGN));
         
@@ -760 +766 @@
 void *calloc(const size_t nmemb, const size_t size)
 {
+        // FIXME: Check for overflow
+        
         void *block = malloc(nmemb * size);
         if (block == NULL)
@@ -899 +907 @@
         if (addr == NULL)
                 return;
-
+        
         futex_down(&malloc_futex);