Changes in kernel/arch/amd64/include/asm.h [667a4f8:c22531fc] in mainline

File:

• kernel/arch/amd64/include/asm.h (modified) (11 diffs)

kernel/arch/amd64/include/asm.h

@@ -41 +41 @@
 #include <trace.h>
 
+#define IO_SPACE_BOUNDARY       ((void *) (64 * 1024))
+
 /** Return base address of current stack.
  *
@@ -77 +79 @@
 }
 
-#define IO_SPACE_BOUNDARY       ((void *) (64 * 1024))
-
 /** Byte from port
  *
@@ -89 +89 @@
 NO_TRACE static inline uint8_t pio_read_8(ioport8_t *port)
 {
-        if (((void *)port) < IO_SPACE_BOUNDARY) {
+        if (port < (ioport8_t *) IO_SPACE_BOUNDARY) {
                 uint8_t val;
+                
                 asm volatile (
                         "inb %w[port], %b[val]\n"
@@ -96 +97 @@
                         : [port] "d" (port)
                 );
+                
                 return val;
-        } else {
+        } else
                 return (uint8_t) *port;
-        }
 }
 
@@ -112 +113 @@
 NO_TRACE static inline uint16_t pio_read_16(ioport16_t *port)
 {
-        if (((void *)port) < IO_SPACE_BOUNDARY) {
+        if (port < (ioport16_t *) IO_SPACE_BOUNDARY) {
                 uint16_t val;
+                
                 asm volatile (
                         "inw %w[port], %w[val]\n"
@@ -119 +121 @@
                         : [port] "d" (port)
                 );
+                
                 return val;
-        } else {
+        } else
                 return (uint16_t) *port;
-        }
 }
 
@@ -135 +137 @@
 NO_TRACE static inline uint32_t pio_read_32(ioport32_t *port)
 {
-        if (((void *)port) < IO_SPACE_BOUNDARY) {
+        if (port < (ioport32_t *) IO_SPACE_BOUNDARY) {
                 uint32_t val;
+                
                 asm volatile (
                         "inl %w[port], %[val]\n"
@@ -142 +145 @@
                         : [port] "d" (port)
                 );
+                
                 return val;
-        } else {
+        } else
                 return (uint32_t) *port;
-        }
 }
 
@@ -158 +161 @@
 NO_TRACE static inline void pio_write_8(ioport8_t *port, uint8_t val)
 {
-        if (((void *)port) < IO_SPACE_BOUNDARY) {
+        if (port < (ioport8_t *) IO_SPACE_BOUNDARY) {
                 asm volatile (
                         "outb %b[val], %w[port]\n"
                         :: [val] "a" (val), [port] "d" (port)
                 );      
-        } else {
-                *((uint8_t *) port) = val;
-        }
+        } else
+                *port = val;
 }
 
@@ -178 +180 @@
 NO_TRACE static inline void pio_write_16(ioport16_t *port, uint16_t val)
 {
-        if (((void *)port) < IO_SPACE_BOUNDARY) {
+        if (port < (ioport16_t *) IO_SPACE_BOUNDARY) {
                 asm volatile (
                         "outw %w[val], %w[port]\n"
                         :: [val] "a" (val), [port] "d" (port)
                 );
-        } else {
-                *((uint16_t *) port) = val;
-        }
+        } else
+                *port = val;
 }
 
@@ -198 +199 @@
 NO_TRACE static inline void pio_write_32(ioport32_t *port, uint32_t val)
 {
-        if (((void *)port) < IO_SPACE_BOUNDARY) {
+        if (port < (ioport32_t *) IO_SPACE_BOUNDARY) {
                 asm volatile (
                         "outl %[val], %w[port]\n"
                         :: [val] "a" (val), [port] "d" (port)
                 );
-        } else {
-                *((uint32_t *) port) = val;
-        }
+        } else
+                *port = val;
 }