Changeset c0ea739 in mainline for kernel/generic/src/sysinfo/sysinfo.c

Timestamp:

2018-11-09T22:03:24Z (5 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b9a2725

Parents:

88e43bc

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-08 01:00:44)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-09 22:03:24)

Message:

Allow sysinfo_create_path() to fail gracefully

File:

• kernel/generic/src/sysinfo/sysinfo.c (modified) (9 diffs)

kernel/generic/src/sysinfo/sysinfo.c

@@ -205 +205 @@
                 *psubtree =
                     (sysinfo_item_t *) slab_alloc(sysinfo_item_cache, 0);
-                assert(*psubtree);
+                if (!*psubtree)
+                        return NULL;
 
                 /* Fill in item name up to the delimiter */
                 (*psubtree)->name = str_ndup(name, i);
-                assert((*psubtree)->name);
+                if (!(*psubtree)->name) {
+                        slab_free(sysinfo_item_cache, *psubtree);
+                        return NULL;
+                }
 
                 /* Create subtree items */
                 if (name[i] == '.') {
                         (*psubtree)->subtree_type = SYSINFO_SUBTREE_TABLE;
-                        return sysinfo_create_path(name + i + 1,
+                        sysinfo_item_t *item = sysinfo_create_path(name + i + 1,
                             &((*psubtree)->subtree.table));
+                        if (!item) {
+                                free((*psubtree)->name);
+                                slab_free(sysinfo_item_cache, *psubtree);
+                        }
+                        return item;
                 }
 
@@ -272 +281 @@
                         sysinfo_item_t *item =
                             (sysinfo_item_t *) slab_alloc(sysinfo_item_cache, 0);
-                        assert(item);
+                        if (!item)
+                                return NULL;
 
                         cur->next = item;
@@ -278 +288 @@
                         /* Fill in item name up to the delimiter */
                         item->name = str_ndup(name, i);
-                        assert(item->name);
+                        if (!item->name) {
+                                slab_free(sysinfo_item_cache, item);
+                                return NULL;
+                        }
 
                         /* Create subtree items */
                         if (name[i] == '.') {
                                 item->subtree_type = SYSINFO_SUBTREE_TABLE;
-                                return sysinfo_create_path(name + i + 1,
-                                    &(item->subtree.table));
+                                sysinfo_item_t *sub = sysinfo_create_path(
+                                    name + i + 1, &(item->subtree.table));
+                                if (!sub) {
+                                        free(item->name);
+                                        slab_free(sysinfo_item_cache, item);
+                                        return NULL;
+                                }
+                                return sub;
                         }
 
@@ -318 +337 @@
                 item->val_type = SYSINFO_VAL_VAL;
                 item->val.val = val;
+        } else {
+                printf("Could not set sysinfo item %s.\n", name);
         }
 
@@ -350 +371 @@
                 item->val.data.data = data;
                 item->val.data.size = size;
+        } else {
+                printf("Could not set sysinfo item %s.\n", name);
         }
 
@@ -378 +401 @@
                 item->val.gen_val.fn = fn;
                 item->val.gen_val.data = data;
+        } else {
+                printf("Could not set sysinfo item %s.\n", name);
         }
 
@@ -411 +436 @@
                 item->val.gen_data.fn = fn;
                 item->val.gen_data.data = data;
+        } else {
+                printf("Could not set sysinfo item %s.\n", name);
         }
 
@@ -434 +461 @@
         if (item != NULL)
                 item->val_type = SYSINFO_VAL_UNDEFINED;
+        else
+                printf("Could not set sysinfo item %s.\n", name);
 
         mutex_unlock(&sysinfo_lock);
@@ -466 +495 @@
                 item->subtree.generator.fn = fn;
                 item->subtree.generator.data = data;
+        } else {
+                printf("Could not set sysinfo item %s.\n", name);
         }