Changes in / [ce8c848:bb0d3d24] in mainline

File:

• uspace/srv/fs/tmpfs/tmpfs_ops.c (modified) (13 diffs)

uspace/srv/fs/tmpfs/tmpfs_ops.c

@@ -147 +147 @@
 hash_table_t nodes;
 
-#define NODES_KEY_INDEX 0
-#define NODES_KEY_DEV   1
+#define NODES_KEY_DEV   0       
+#define NODES_KEY_INDEX 1
 
 /* Implementation of hash table interface for the nodes hash table. */
@@ -166 +166 @@
 static void nodes_remove_callback(link_t *item)
 {
+        tmpfs_node_t *nodep = hash_table_get_instance(item, tmpfs_node_t,
+            nh_link);
+
+        while (!list_empty(&nodep->cs_head)) {
+                tmpfs_dentry_t *dentryp = list_get_instance(nodep->cs_head.next,
+                    tmpfs_dentry_t, link);
+
+                assert(nodep->type == TMPFS_DIRECTORY);
+                list_remove(&dentryp->link);
+                free(dentryp);
+        }
+
+        if (nodep->data) {
+                assert(nodep->type == TMPFS_FILE);
+                free(nodep->data);
+        }
+        free(nodep->bp);
+        free(nodep);
 }
 
@@ -215 +233 @@
 }
 
+static void tmpfs_instance_done(dev_handle_t dev_handle)
+{
+        unsigned long key[] = {
+                [NODES_KEY_DEV] = dev_handle
+        };
+        /*
+         * Here we are making use of one special feature of our hash table
+         * implementation, which allows to remove more items based on a partial
+         * key match. In the following, we are going to remove all nodes
+         * matching our device handle. The nodes_remove_callback() function will
+         * take care of resource deallocation.
+         */
+        hash_table_remove(&nodes, key, 1);
+}
+
 int tmpfs_match(fs_node_t **rfn, fs_node_t *pfn, const char *component)
 {
@@ -237 +270 @@
 {
         unsigned long key[] = {
-                [NODES_KEY_INDEX] = index,
-                [NODES_KEY_DEV] = dev_handle
+                [NODES_KEY_DEV] = dev_handle,
+                [NODES_KEY_INDEX] = index
         };
         link_t *lnk = hash_table_find(&nodes, key);
@@ -296 +329 @@
         /* Insert the new node into the nodes hash table. */
         unsigned long key[] = {
-                [NODES_KEY_INDEX] = nodep->index,
-                [NODES_KEY_DEV] = nodep->dev_handle
+                [NODES_KEY_DEV] = nodep->dev_handle,
+                [NODES_KEY_INDEX] = nodep->index
         };
         hash_table_insert(&nodes, key, &nodep->nh_link);
@@ -312 +345 @@
 
         unsigned long key[] = {
-                [NODES_KEY_INDEX] = nodep->index,
-                [NODES_KEY_DEV] = nodep->dev_handle
+                [NODES_KEY_DEV] = nodep->dev_handle,
+                [NODES_KEY_INDEX] = nodep->index
         };
         hash_table_remove(&nodes, key, 2);
 
-        if (nodep->type == TMPFS_FILE)
-                free(nodep->data);
-        free(nodep->bp);
-        free(nodep);
+        /*
+         * The nodes_remove_callback() function takes care of the actual
+         * resource deallocation.
+         */
         return EOK;
 }
@@ -424 +457 @@
         /* Initialize TMPFS instance. */
         if (!tmpfs_instance_init(dev_handle)) {
+                free(opts);
                 ipc_answer_0(rid, ENOMEM);
                 return;
@@ -442 +476 @@
                     rootp->lnkcnt);
         }
+        free(opts);
 }
 
@@ -451 +486 @@
 void tmpfs_unmounted(ipc_callid_t rid, ipc_call_t *request)
 {
-        ipc_answer_0(rid, ENOTSUP);
+        dev_handle_t dev_handle = (dev_handle_t) IPC_GET_ARG1(*request);
+
+        tmpfs_instance_done(dev_handle);
+        ipc_answer_0(rid, EOK);
 }
 
@@ -475 +513 @@
         link_t *hlp;
         unsigned long key[] = {
-                [NODES_KEY_INDEX] = index,
                 [NODES_KEY_DEV] = dev_handle,
+                [NODES_KEY_INDEX] = index
         };
         hlp = hash_table_find(&nodes, key);
@@ -549 +587 @@
         link_t *hlp;
         unsigned long key[] = {
-                [NODES_KEY_INDEX] = index,
-                [NODES_KEY_DEV] = dev_handle
+                [NODES_KEY_DEV] = dev_handle,
+                [NODES_KEY_INDEX] = index
         };
         hlp = hash_table_find(&nodes, key);
@@ -613 +651 @@
         link_t *hlp;
         unsigned long key[] = {
-                [NODES_KEY_INDEX] = index,
-                [NODES_KEY_DEV] = dev_handle
+                [NODES_KEY_DEV] = dev_handle,
+                [NODES_KEY_INDEX] = index
         };
         hlp = hash_table_find(&nodes, key);
@@ -656 +694 @@
         link_t *hlp;
         unsigned long key[] = {
-                [NODES_KEY_INDEX] = index,
-                [NODES_KEY_DEV] = dev_handle
+                [NODES_KEY_DEV] = dev_handle,
+                [NODES_KEY_INDEX] = index
         };
         hlp = hash_table_find(&nodes, key);