Changeset ba5ab09 in mainline

Timestamp:

2011-01-28T14:36:47Z (13 years ago)

Author:

Matus Dekanek <smekideki@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

89beb08, aec2ad4

Parents:

81c0854f

Message:

fixed one possible memory leak
using fibril_mutex instead of futex

Location:

uspace/drv/usbhub

Files:

• main.c (modified) (2 diffs)
• usbhub.c (modified) (4 diffs)
• usbhub_private.h (modified) (2 diffs)

uspace/drv/usbhub/main.c

@@ -42 +42 @@
 
 usb_general_list_t usb_hub_list;
-futex_t usb_hub_list_lock;
+fibril_mutex_t usb_hub_list_lock;
 
 static driver_ops_t hub_driver_ops = {
@@ -65 +65 @@
 {
         usb_dprintf_enable(NAME, 0);
-
-        futex_initialize(&usb_hub_list_lock, 0);
+        
+        fibril_mutex_initialize(&usb_hub_list_lock);
+        fibril_mutex_lock(&usb_hub_list_lock);
         usb_lst_init(&usb_hub_list);
-        futex_up(&usb_hub_list_lock);
+        fibril_mutex_unlock(&usb_hub_list_lock);
 
         fid_t fid = fibril_create(usb_hub_control_loop, NULL);

uspace/drv/usbhub/usbhub.c

@@ -203 +203 @@
 
         //add the hub to list
-        futex_down(&usb_hub_list_lock);
+        fibril_mutex_lock(&usb_hub_list_lock);
         usb_lst_append(&usb_hub_list, hub_info);
-        futex_up(&usb_hub_list_lock);
+        fibril_mutex_unlock(&usb_hub_list_lock);
 
         dprintf(1, "hub info added to list");
@@ -445 +445 @@
          */
         usb_general_list_t * lst_item;
-        futex_down(&usb_hub_list_lock);
+        fibril_mutex_lock(&usb_hub_list_lock);
         for (lst_item = usb_hub_list.next;
                         lst_item != &usb_hub_list;
                         lst_item = lst_item->next) {
-                futex_up(&usb_hub_list_lock);
+                fibril_mutex_unlock(&usb_hub_list_lock);
                 usb_hub_info_t * hub_info = ((usb_hub_info_t*)lst_item->data);
                 /*
@@ -488 +488 @@
 
                 if (opResult != EOK) {
+                        free(change_bitmap);
                         dprintf(1, "something went wrong while getting status of hub");
                         continue;
@@ -503 +504 @@
 
                 ipc_hangup(hc);
-                futex_down(&usb_hub_list_lock);
-        }
-        futex_up(&usb_hub_list_lock);
+                fibril_mutex_lock(&usb_hub_list_lock);
+        }
+        fibril_mutex_unlock(&usb_hub_list_lock);
 }
 

uspace/drv/usbhub/usbhub_private.h

@@ -43 +43 @@
 #include <bool.h>
 #include <driver.h>
-#include <futex.h>
+#include <fibril_synch.h>
 
 #include <usb/usb.h>
@@ -82 +82 @@
 
 /** Lock for hub list*/
-extern futex_t usb_hub_list_lock;
+extern fibril_mutex_t usb_hub_list_lock;