Changeset b5f716b in mainline

Timestamp:

2014-04-18T11:32:09Z (10 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5792d6e

Parents:

80f6be9

Message:

Unbreak optimized-for-size builds (fix maybe-uninitialized)

When possible, converted the maybe-unitialized (in all cases, false alarms)
variables to an assignment with assertion testing that reasonable value
was added.

Files:

• kernel/generic/src/udebug/udebug_ipc.c (modified) (4 diffs)
• uspace/drv/bus/pci/pciintel/pci.c (modified) (1 diff)
• uspace/srv/net/dhcp/transport.c (modified) (2 diffs)
• uspace/srv/net/dnsrsrv/dns_msg.c (modified) (3 diffs)
• uspace/srv/net/dnsrsrv/transport.c (modified) (2 diffs)

kernel/generic/src/udebug/udebug_ipc.c

@@ -343 +343 @@
         sysarg_t uspace_addr;
         sysarg_t to_copy;
-        void *buffer;
+        void *buffer = NULL;
         int rc;
 
@@ -354 +354 @@
                 return;
         }
+
+        ASSERT(buffer != NULL);
 
         /*
@@ -385 +387 @@
         sysarg_t uspace_src;
         unsigned size;
-        void *buffer;
+        void *buffer = NULL;
         int rc;
 
@@ -398 +400 @@
                 return;
         }
+
+        ASSERT(buffer != NULL);
 
         IPC_SET_RETVAL(call->data, 0);

uspace/drv/bus/pci/pciintel/pci.c

@@ -284 +284 @@
         const uint32_t conf_addr = CONF_ADDR(fun->bus, fun->dev, fun->fn, reg);
         pci_bus_t *bus = pci_bus_from_fun(fun);
-        uint32_t val;
+        uint32_t val = 0; // Prevent -Werror=maybe-uninitialized
         
         fibril_mutex_lock(&bus->conf_mutex);

uspace/srv/net/dhcp/transport.c

@@ -172 +172 @@
         dhcp_transport_t *dt = (dhcp_transport_t *)arg;
         void *msg;
-        size_t size;
+        size_t size = (size_t) -1;
         int rc;
 
@@ -179 +179 @@
                 if (rc != EOK)
                         break;
+
+                assert(size != (size_t) -1);
 
                 dt->recv_cb(dt->cb_arg, msg, size);

uspace/srv/net/dnsrsrv/dns_msg.c

@@ -487 +487 @@
         size_t size;
         dns_header_t hdr;
-        size_t q_size;
+        size_t q_size = 0;
         size_t di;
         int rc;
@@ -515 +515 @@
                         return rc;
 
+                assert(q_size > 0);
+
                 size += q_size;
         }
@@ -532 +534 @@
                         return rc;
                 }
+
+                assert(q_size > 0);
 
                 di += q_size;

uspace/srv/net/dnsrsrv/transport.c

@@ -286 +286 @@
 static int transport_recv_fibril(void *arg)
 {
-        dns_message_t *resp;
+        dns_message_t *resp = NULL;
         trans_req_t *treq;
         int rc;
@@ -294 +294 @@
                 if (rc != EOK)
                         continue;
+
+                assert(resp != NULL);
 
                 fibril_mutex_lock(&treq_lock);