Changeset b366a1bc in mainline

Timestamp:

2011-02-03T20:01:19Z (13 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

956d4df8, e950803

Parents:

9c31643

Message:

Do not use memory after free.

File:

• uspace/srv/fs/devfs/devfs_ops.c (modified) (4 diffs)

uspace/srv/fs/devfs/devfs_ops.c

@@ -130 +130 @@
 {
         devfs_node_t *node = (devfs_node_t *) pfn->data;
+        int ret;
         
         if (node->handle == 0) {
@@ -145 +146 @@
                                 
                                 if (str_cmp(devs[pos].name, component) == 0) {
+                                        ret = devfs_node_get_internal(rfn, DEV_HANDLE_NAMESPACE, devs[pos].handle);
                                         free(devs);
-                                        return devfs_node_get_internal(rfn, DEV_HANDLE_NAMESPACE, devs[pos].handle);
+                                        return ret;
                                 }
                         }
@@ -162 +164 @@
                                 for (pos = 0; pos < count; pos++) {
                                         if (str_cmp(devs[pos].name, component) == 0) {
+                                                ret = devfs_node_get_internal(rfn, DEV_HANDLE_DEVICE, devs[pos].handle);
                                                 free(devs);
-                                                return devfs_node_get_internal(rfn, DEV_HANDLE_DEVICE, devs[pos].handle);
+                                                return ret;
                                         }
                                 }
@@ -184 +187 @@
                         for (pos = 0; pos < count; pos++) {
                                 if (str_cmp(devs[pos].name, component) == 0) {
+                                        ret = devfs_node_get_internal(rfn, DEV_HANDLE_DEVICE, devs[pos].handle);
                                         free(devs);
-                                        return devfs_node_get_internal(rfn, DEV_HANDLE_DEVICE, devs[pos].handle);
+                                        return ret;
                                 }
                         }