Changeset b25199bc in mainline

Timestamp:

2011-12-07T15:33:22Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

89128f3

Parents:

481dec00

Message:

usbinfo: Check for available strings sooner and bail out if there are none.

File:

• uspace/app/usbinfo/info.c (modified) (2 diffs)

uspace/app/usbinfo/info.c

@@ -287 +287 @@
 void dump_strings(usbinfo_device_t *dev)
 {
+        /* Find used indexes. Devices with more than 64 strings are very rare.*/
+        uint64_t str_mask = 0;
+        find_string_indexes_callback((uint8_t *)&dev->device_descriptor, 0,
+            &str_mask);
+        usb_dp_walk_simple(dev->full_configuration_descriptor,
+            dev->full_configuration_descriptor_size,
+            usb_dp_standard_descriptor_nesting,
+            find_string_indexes_callback,
+            &str_mask);
+
+        if (str_mask == 0) {
+                printf("Device does not support string descriptors.\n");
+                return;
+        }
+
         /* Get supported languages. */
         l18_win_locales_t *langs;
@@ -305 +320 @@
         }
         printf(".\n");
-
-        /* Find used indexes. Device with more than 64 strings are very rare.
-         */
-        uint64_t str_mask = 0;
-        find_string_indexes_callback((uint8_t *)&dev->device_descriptor, 0,
-            &str_mask);
-        usb_dp_walk_simple(dev->full_configuration_descriptor,
-            dev->full_configuration_descriptor_size,
-            usb_dp_standard_descriptor_nesting,
-            find_string_indexes_callback,
-            &str_mask);
 
         /* Get all strings and dump them. */