Changeset adb1ae9 in mainline

Timestamp:

2017-11-09T20:29:25Z (6 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

731d8f9

Parents:

0239846

Message:

Answer IPC only when there will be no blocking

This is necessary so that a parallel exchange is not handled by a
connection fibril which is still itself waiting for IPC or resources.

File:

• uspace/srv/locsrv/locsrv.c (modified) (2 diffs)

uspace/srv/locsrv/locsrv.c

@@ -557 +557 @@
         fibril_mutex_unlock(&cdir.mutex);
         fibril_mutex_unlock(&services_list_mutex);
+
+        /*
+         * First send out all notifications and only then answer the request.
+         * Otherwise the current fibril might block and transitively wait for
+         * the completion of requests that are routed to it via an IPC loop.
+         */
+        loc_category_change_event();
         async_answer_0(iid, EOK);
-
-        loc_category_change_event();
 }
 
@@ -1297 +1302 @@
         fibril_mutex_unlock(&services_list_mutex);
 
+        /*
+         * First send out all notifications and only then answer the request.
+         * Otherwise the current fibril might block and transitively wait for
+         * the completion of requests that are routed to it via an IPC loop.
+         */
+        loc_category_change_event();
         async_answer_0(iid, retval);
-
-        loc_category_change_event();
 }