Changeset ad2718d in mainline

Timestamp:

2012-04-18T23:12:57Z (12 years ago)

Author:

Maurizio Lombardi <m.lombardi85@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

86e81a9

Parents:

0885f7e

Message:

date: improve comments and bad parameter format detection

File:

• uspace/app/date/date.c (modified) (4 diffs)

uspace/app/date/date.c

@@ -194 +194 @@
 }
 
+/** Read the day, month and year from a string
+ *  with the following format: DD/MM/YYYY
+ */
 static int
 read_date_from_arg(char *wdate, struct tm *t)
@@ -199 +202 @@
         int rc;
 
-        if (str_size(wdate) != 10) /* DD/MM/YYYY */
+        if (str_size(wdate) != 10) /* str_size("DD/MM/YYYY") == 10 */
                 return EINVAL;
 
@@ -221 +224 @@
 }
 
+/** Read the hours, minutes and seconds from a string
+ *  with the following format: HH:MM:SS or HH:MM
+ */
 static int
 read_time_from_arg(char *wtime, struct tm *t)
@@ -226 +232 @@
         int rc;
         size_t len = str_size(wtime);
-        bool sec_present = len > 5;
-
-        if (len > 8 || len < 5) /* HH:MM[:SS] */
+        bool sec_present = len == 8;
+
+        /* str_size("HH:MM") == 5 */
+        /* str_size("HH:MM:SS") == 8 */
+        if (len != 8 && len != 5)
                 return EINVAL;