Changeset ac9e79d in mainline

Timestamp:

2018-11-06T19:52:51Z (5 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b294126

Parents:

4a8d0dd1

Message:

Fix as_t reference counting

Commit 78de83de52a9115dc77b09bb7029403dad8c2fb0 changed the way how
reference counting works for newly created objects, but didn't remove
the explicit bumping of reference count for address spaces, which had
been necessary before that. Because of that, as_t structures were never
deallocated.

Location:

kernel/generic/src

Files:

• mm/as.c (modified) (1 diff)
• proc/task.c (modified) (1 diff)

kernel/generic/src/mm/as.c

@@ -137 +137 @@
         if (!AS_KERNEL)
                 panic("Cannot create kernel address space.");
-
-        /*
-         * Make sure the kernel address space
-         * reference count never drops to zero.
-         */
-        as_hold(AS_KERNEL);
 }
 

kernel/generic/src/proc/task.c

@@ -252 +252 @@
         futex_task_init(task);
 
-        /*
-         * Get a reference to the address space.
-         */
-        as_hold(task->as);
-
         irq_spinlock_lock(&tasks_lock, true);