Changeset ab34cc9 in mainline

Timestamp:

2011-08-19T18:03:34Z (13 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7b2a7ad

Parents:

16f9782

Message:

Make IPC_M_CONNECT_TO_ME more consistent with IPC_M_CONNECT_TO_ME.

• Instead of passing the task ID of the connecting task in IPC argument 3 and 4, pass it in ipc_call_t::in_task_id.
• Actually, all answers are signed by the answering task ID like this.

Files:

• abi/include/ipc/methods.h (modified) (1 diff)
• kernel/generic/include/ipc/ipc.h (modified) (1 diff)
• kernel/generic/src/ipc/ipc.c (modified) (1 diff)
• kernel/generic/src/ipc/sysipc.c (modified) (1 diff)
• uspace/lib/c/generic/async.c (modified) (1 diff)
• uspace/lib/c/generic/ipc.c (modified) (1 diff)

abi/include/ipc/methods.h

@@ -96 +96 @@
  *                       error is sent back to caller. Otherwise 
  *                       the call is accepted and the response is sent back.
- *                     - the hash of the client task is passed to userspace
- *                       (on the receiving side) as ARG4 of the call.
  *                     - the hash of the allocated phone is passed to userspace
  *                       (on the receiving side) as ARG5 of the call.

kernel/generic/include/ipc/ipc.h

@@ -98 +98 @@
 typedef struct {
         sysarg_t args[IPC_CALL_LEN];
-        /** Task which made or forwarded the call with IPC_FF_ROUTE_FROM_ME. */
+        /**
+         * Task which made or forwarded the call with IPC_FF_ROUTE_FROM_ME,
+         * or the task which answered the call.
+         */
         task_id_t task_id;
         /** Phone which made or last masqueraded this call. */

kernel/generic/src/ipc/ipc.c

@@ -230 +230 @@
                 }
         }
+
+        call->data.task_id = TASK->taskid;
         
         if (do_lock)

kernel/generic/src/ipc/sysipc.c

@@ -253 +253 @@
                         /* The connection was accepted */
                         phone_connect(phoneid, &answer->sender->answerbox);
-                        /* Set 'task ID' as arg3 and arg4 of response */
-                        IPC_SET_ARG3(answer->data, LOWER32(TASK->taskid));
-                        IPC_SET_ARG4(answer->data, UPPER32(TASK->taskid));
                         /* Set 'phone hash' as arg5 of response */
                         IPC_SET_ARG5(answer->data,

uspace/lib/c/generic/async.c

@@ -1472 +1472 @@
                 return ENOENT;
         
-        task_id_t task_id;
-        sysarg_t task_id_lo;
-        sysarg_t task_id_hi;
         sysarg_t phone_hash;
-        int rc = async_req_3_5(exch, IPC_M_CONNECT_TO_ME, arg1, arg2, arg3,
-            NULL, NULL, &task_id_lo, &task_id_hi, &phone_hash);
+        sysarg_t rc;
+
+        aid_t req;
+        ipc_call_t answer;
+        req = async_send_3(exch, IPC_M_CONNECT_TO_ME, arg1, arg2, arg3,
+            &answer);
+        async_wait_for(req, &rc);
         if (rc != EOK)
-                return rc;
-
-        task_id = (task_id_t) MERGE_LOUP32(task_id_lo, task_id_hi);
-        
+                return (int) rc;
+
+        phone_hash = IPC_GET_ARG5(answer);
+
         if (client_receiver != NULL)
-                async_new_connection(task_id, phone_hash, 0, NULL,
+                async_new_connection(answer.in_task_id, phone_hash, 0, NULL,
                     client_receiver, carg);
         

uspace/lib/c/generic/ipc.c

@@ -629 +629 @@
     task_id_t *task_id, sysarg_t *phonehash)
 {
-        sysarg_t task_id_lo = 0;
-        sysarg_t task_id_hi = 0;
-        int rc;
-
-        rc = ipc_call_sync_3_5(phoneid, IPC_M_CONNECT_TO_ME, arg1, arg2, arg3,
-            NULL, NULL, &task_id_lo, &task_id_hi, phonehash);
-
-        *task_id = (task_id_t) MERGE_LOUP32(task_id_lo, task_id_hi);
+        ipc_call_t data;
+        int rc = __SYSCALL6(SYS_IPC_CALL_SYNC_FAST, phoneid,
+            IPC_M_CONNECT_TO_ME, arg1, arg2, arg3, (sysarg_t) &data);
+        if (rc == EOK) {
+                *task_id = data.in_task_id;
+                *phonehash = IPC_GET_ARG5(data);
+        }       
         return rc;
 }