Changeset aa81adc in mainline for uspace/drv/bus/usb/vhc/connhost.c

Timestamp:

2011-07-11T09:28:00Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ece7f78

Parents:

1cb4f05

Message:

libusbhost: endpoint_t uses get/destroy pair, instead of init/destroy.

endpoint_init always returned EOK, thus allocation could be moved in.
Also, it makes no sense to create this structures on stack.

File:

• uspace/drv/bus/usb/vhc/connhost.c (modified) (1 diff)

uspace/drv/bus/usb/vhc/connhost.c

@@ -141 +141 @@
     size_t max_packet_size, unsigned int interval)
 {
-        VHC_DATA(vhc, fun);
-
-        endpoint_t *ep = malloc(sizeof(endpoint_t));
+        /* TODO: Use usb_endpoint_manager_add_ep */
+        VHC_DATA(vhc, fun);
+
+        endpoint_t *ep = endpoint_get(
+            address, endpoint, direction, transfer_type, USB_SPEED_FULL, 1);
         if (ep == NULL) {
                 return ENOMEM;
         }
 
-        int rc = endpoint_init(ep, address, endpoint, direction, transfer_type,
-            USB_SPEED_FULL, 1);
-        if (rc != EOK) {
-                free(ep);
-                return rc;
-        }
-
-        rc = usb_endpoint_manager_register_ep(&vhc->ep_manager, ep, 1);
+        int rc = usb_endpoint_manager_register_ep(&vhc->ep_manager, ep, 1);
         if (rc != EOK) {
                 endpoint_destroy(ep);