Changeset a1b9f63 in mainline for kernel/generic/src/console/cmd.c

Timestamp:

2018-08-31T10:32:40Z (6 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

6bf5b8c

Parents:

b1834a01

git-author:

Jakub Jermar <jakub@…> (2018-08-31 09:54:11)

git-committer:

Jakub Jermar <jakub@…> (2018-08-31 10:32:40)

Message:

Add alignment argument to km_map()

km_map() currently always applies alignment requirement equal to the
size of the mapped region. Most of the time, the natural alignment is
unnecessarily strong and especially on 32-bit systems may contribute to
km_map() failures for regions with size in the order of several hundred
megabytes.

This change adds an extra argument to km_map() which allows the caller
to indicate the desired alignment. The old behaviour can be specified
by passing KM_NATURAL_ALIGNMENT as alignment.

This change only adds the alignment argument, but does not change the
alignment requirement anywhere.

File:

• kernel/generic/src/console/cmd.c (modified) (6 diffs)

kernel/generic/src/console/cmd.c

@@ -728 +728 @@
 #endif
                 ptr = (uint8_t *) km_map(argv[0].intval, sizeof(uint8_t),
-                    PAGE_NOT_CACHEABLE);
+                    PAGE_SIZE, PAGE_NOT_CACHEABLE);
 
         const uint8_t val = pio_read_8(ptr);
@@ -758 +758 @@
 #endif
                 ptr = (uint16_t *) km_map(argv[0].intval, sizeof(uint16_t),
-                    PAGE_NOT_CACHEABLE);
+                    PAGE_SIZE, PAGE_NOT_CACHEABLE);
 
         const uint16_t val = pio_read_16(ptr);
@@ -788 +788 @@
 #endif
                 ptr = (uint32_t *) km_map(argv[0].intval, sizeof(uint32_t),
-                    PAGE_NOT_CACHEABLE);
+                    PAGE_SIZE, PAGE_NOT_CACHEABLE);
 
         const uint32_t val = pio_read_32(ptr);
@@ -818 +818 @@
 #endif
                 ptr = (uint8_t *) km_map(argv[0].intval, sizeof(uint8_t),
-                    PAGE_NOT_CACHEABLE);
+                    PAGE_SIZE, PAGE_NOT_CACHEABLE);
 
         printf("write %" PRIxn ": %" PRIx8 "\n", argv[0].intval,
@@ -849 +849 @@
 #endif
                 ptr = (uint16_t *) km_map(argv[0].intval, sizeof(uint16_t),
-                    PAGE_NOT_CACHEABLE);
+                    PAGE_SIZE, PAGE_NOT_CACHEABLE);
 
         printf("write %" PRIxn ": %" PRIx16 "\n", argv[0].intval,
@@ -880 +880 @@
 #endif
                 ptr = (uint32_t *) km_map(argv[0].intval, sizeof(uint32_t),
-                    PAGE_NOT_CACHEABLE);
+                    PAGE_SIZE, PAGE_NOT_CACHEABLE);
 
         printf("write %" PRIxn ": %" PRIx32 "\n", argv[0].intval,