Changeset a1732929 in mainline for uspace/lib/usbhost/src/ddf_helpers.c

Timestamp:

2018-01-15T17:04:34Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ff99e8

Parents:

c1a966e

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:34)

Message:

usb: unified logging

Use logger instead of printf. Logger adds newlines automatically.

File:

• uspace/lib/usbhost/src/ddf_helpers.c (modified) (8 diffs)

uspace/lib/usbhost/src/ddf_helpers.c

@@ -133 +133 @@
         assert(dev);
 
-        usb_log_debug("Device %d requested default address at %s speed\n",
+        usb_log_debug("Device %d requested default address at %s speed",
             dev->address, usb_str_speed(speed));
         return bus_reserve_default_address(hcd->bus, speed);
@@ -152 +152 @@
         assert(dev);
 
-        usb_log_debug("Device %d released default address\n", dev->address);
+        usb_log_debug("Device %d released default address", dev->address);
         bus_release_default_address(hcd->bus);
 
@@ -173 +173 @@
         assert(hub);
 
-        usb_log_debug("Hub %d reported a new USB device on port: %u\n",
+        usb_log_debug("Hub %d reported a new USB device on port: %u",
             hub->address, port);
         return hcd_ddf_new_device(hcd, hc, hub, port);
@@ -185 +185 @@
         assert(ddf_dev);
         assert(dev);
-        usb_log_debug("Hub `%s' reported removal of device on port %u\n",
+        usb_log_debug("Hub `%s' reported removal of device on port %u",
             ddf_fun_get_name(fun), port);
         return hcd_ddf_remove_device(ddf_dev, dev, port);
@@ -535 +535 @@
         hc_device_t *instance = ddf_dev_data_alloc(device, size);
         if (instance == NULL) {
-                usb_log_error("Failed to allocate HCD ddf structure.\n");
+                usb_log_error("Failed to allocate HCD ddf structure.");
                 return ENOMEM;
         }
@@ -543 +543 @@
         instance->ctl_fun = ddf_fun_create(device, fun_exposed, "ctl");
         if (!instance->ctl_fun) {
-                usb_log_error("Failed to create HCD ddf fun.\n");
+                usb_log_error("Failed to create HCD ddf fun.");
                 goto err_destroy_fun;
         }
@@ -549 +549 @@
         ret = ddf_fun_bind(instance->ctl_fun);
         if (ret != EOK) {
-                usb_log_error("Failed to bind ctl_fun: %s.\n", str_error(ret));
+                usb_log_error("Failed to bind ctl_fun: %s.", str_error(ret));
                 goto err_destroy_fun;
         }
@@ -555 +555 @@
         ret = ddf_fun_add_to_category(instance->ctl_fun, USB_HC_CATEGORY);
         if (ret != EOK) {
-                usb_log_error("Failed to add fun to category: %s.\n",
+                usb_log_error("Failed to add fun to category: %s.",
                     str_error(ret));
                 ddf_fun_unbind(instance->ctl_fun);