Changeset a1732929 in mainline for uspace/drv/hid/usbhid/main.c

Timestamp:

2018-01-15T17:04:34Z (6 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9ff99e8

Parents:

c1a966e

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:32)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-15 17:04:34)

Message:

usb: unified logging

Use logger instead of printf. Logger adds newlines automatically.

File:

• uspace/drv/hid/usbhid/main.c (modified) (8 diffs)

uspace/drv/hid/usbhid/main.c

@@ -58 +58 @@
 static int usb_hid_device_add(usb_device_t *dev)
 {
-        usb_log_debug("%s\n", __FUNCTION__);
+        usb_log_debug("%s", __FUNCTION__);
 
         if (dev == NULL) {
-                usb_log_error("Wrong parameter given for add_device().\n");
+                usb_log_error("Wrong parameter given for add_device().");
                 return EINVAL;
         }
@@ -73 +73 @@
             usb_device_data_alloc(dev, sizeof(usb_hid_dev_t));
         if (hid_dev == NULL) {
-                usb_log_error("Failed to create USB/HID device structure.\n");
+                usb_log_error("Failed to create USB/HID device structure.");
                 return ENOMEM;
         }
@@ -79 +79 @@
         int rc = usb_hid_init(hid_dev, dev);
         if (rc != EOK) {
-                usb_log_error("Failed to initialize USB/HID device.\n");
+                usb_log_error("Failed to initialize USB/HID device.");
                 usb_hid_deinit(hid_dev);
                 return rc;
         }
 
-        usb_log_debug("USB/HID device structure initialized.\n");
+        usb_log_debug("USB/HID device structure initialized.");
 
         /* Start automated polling function.
@@ -92 +92 @@
 
         if (rc != EOK) {
-                usb_log_error("Failed to start polling fibril for `%s'.\n",
+                usb_log_error("Failed to start polling fibril for `%s'.",
                     usb_device_get_name(dev));
                 usb_hid_deinit(hid_dev);
@@ -99 +99 @@
         hid_dev->running = true;
 
-        usb_log_info("HID device `%s' ready.\n", usb_device_get_name(dev));
+        usb_log_info("HID device `%s' ready.", usb_device_get_name(dev));
 
         return EOK;
@@ -115 +115 @@
         /* Clean up. */
         usb_hid_deinit(hid_dev);
-        usb_log_info("%s destruction complete.\n", usb_device_get_name(dev));
+        usb_log_info("%s destruction complete.", usb_device_get_name(dev));
 
         return EOK;
@@ -132 +132 @@
         assert(hid_dev);
 
-        usb_log_info("Device %s removed.\n", usb_device_get_name(dev));
+        usb_log_info("Device %s removed.", usb_device_get_name(dev));
         return join_and_clean(dev);
 }
@@ -148 +148 @@
         assert(hid_dev);
 
-        usb_log_info("Device %s gone.\n", usb_device_get_name(dev));
+        usb_log_info("Device %s gone.", usb_device_get_name(dev));
         return join_and_clean(dev);
 }