Changeset 9f9c7fd in mainline for uspace/lib/net/generic/socket_core.c

Timestamp:

2010-10-16T14:50:42Z (14 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

faa3588

Parents:

614d065

Message:

Do not leak the lenghts array in case of error.

File:

• uspace/lib/net/generic/socket_core.c (modified) (1 diff)

uspace/lib/net/generic/socket_core.c

@@ -564 +564 @@
                 
                 // write the fragment lengths
-                ERROR_PROPAGATE(data_reply(lengths,
-                    sizeof(int) * (fragments + 1)));
+                if (ERROR_OCCURRED(data_reply(lengths,
+                    sizeof(int) * (fragments + 1)))) {
+                        free(lengths);
+                        return ERROR_CODE;
+                }
                 next_packet = packet;
                 
                 // write the fragments
                 for (index = 0; index < fragments; ++index) {
-                        ERROR_PROPAGATE(data_reply(packet_get_data(next_packet),
-                            lengths[index]));
+                        ERROR_CODE = data_reply(packet_get_data(next_packet),
+                            lengths[index]);
+                        if (ERROR_OCCURRED(ERROR_CODE)) {
+                                free(lengths);
+                                return ERROR_CODE;
+                        }
                         next_packet = pq_next(next_packet);
                 }