Changeset 9f1362d4 in mainline for uspace/lib/clui/tinput.h

Timestamp:

2010-04-19T19:58:18Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

369a5f8

Parents:

caad59a

Message:

console output improvements

• define new generic styles (STYLE_INVERTED for inverted print and STYLE_SELECTION for selections), use them primarily instead of specifying colors or RGBs
• use console_set_style(fphone(stdout), STYLE_NORMAL) as the correct mean for reseting console settings (instead of specifying conrete hardcoded colors)
• rename console_goto() to console_set_pos() (consistency with console_get_pos())
• use semantically correct unsigned types for console sizes and cursor positions (instead of signed types)
• use unsigned types for sizes and positions in libclui
• top: nicer screen redrawing (do not use console_clear() which causes flickering, but repaint the screen properly — not entirely finished yet)
• initialize mouse pointer coordinates (so the mouse cursor does not behave erratic after boot, unfortunatelly this does not solve ticket #223)

File:

• uspace/lib/clui/tinput.h (modified) (5 diffs)

uspace/lib/clui/tinput.h

@@ -29 +29 @@
 /** @addtogroup libclui
  * @{
- */ 
+ */
 /**
  * @file
@@ -37 +37 @@
 #define LIBCLUI_TINPUT_H_
 
-#define HISTORY_LEN 10
-#define INPUT_MAX_SIZE 1024
+#include <ipc/ipc.h>
+
+#define HISTORY_LEN     10
+#define INPUT_MAX_SIZE  1024
 
 /** Text input field (command line).
@@ -47 +49 @@
         /** Buffer holding text currently being edited */
         wchar_t buffer[INPUT_MAX_SIZE + 1];
+        
         /** Screen coordinates of the top-left corner of the text field */
-        int col0, row0;
+        ipcarg_t col0;
+        ipcarg_t row0;
+        
         /** Screen dimensions */
-        int con_cols, con_rows;
+        ipcarg_t con_cols;
+        ipcarg_t con_rows;
+        
         /** Number of characters in @c buffer */
-        int nc;
+        size_t nc;
+        
         /** Caret position within buffer */
-        int pos;
+        size_t pos;
+        
         /** Selection mark position within buffer */
-        int sel_start;
-
+        size_t sel_start;
+        
         /** History (dynamically allocated strings) */
-        char *history[1 + HISTORY_LEN];
+        char *history[HISTORY_LEN + 1];
+        
         /** Number of entries in @c history, not counting [0] */
-        int hnum;
+        size_t hnum;
+        
         /** Current position in history */
-        int hpos;
+        size_t hpos;
+        
         /** @c true if finished with this line (return to caller) */
         bool done;
+        
         /** @c true if user requested to abort interactive loop */
         bool exit_clui;
@@ -71 +84 @@
 
 extern tinput_t *tinput_new(void);
-extern void tinput_destroy(tinput_t *ti);
-extern int tinput_read(tinput_t *ti, char **str);
+extern void tinput_destroy(tinput_t *);
+extern int tinput_read(tinput_t *, char **);
 
 #endif
@@ -78 +91 @@
 /** @}
  */
-