Changeset 962ef67 in mainline

Timestamp:

2011-10-22T08:45:56Z (13 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

5984107

Parents:

dce7e41

Message:

sb16: Fix offset by one, zero device buffer.

File:

• uspace/drv/audio/sb16/dsp.c (modified) (3 diffs)

uspace/drv/audio/sb16/dsp.c

@@ -114 +114 @@
                 dsp->buffer.position = buffer;
                 dsp->buffer.size = BUFFER_SIZE;
-                memset(buffer, 0x8f, BUFFER_SIZE);
+                bzero(buffer, BUFFER_SIZE);
                 dma_prepare_channel(SB_DMA_CHAN_16, false, true, BLOCK_DMA);
                 /* Set 8bit channel */
@@ -196 +196 @@
                 sb_dsp_write(dsp, SINGLE_DMA_16B_DA);
                 sb_dsp_write(dsp, dsp->playing.mode);
-                sb_dsp_write(dsp, remain_size & 0xff);
-                sb_dsp_write(dsp, remain_size >> 8);
+                sb_dsp_write(dsp, (remain_size - 1) & 0xff);
+                sb_dsp_write(dsp, (remain_size - 1) >> 8);
                 return;
         }
@@ -262 +262 @@
         sb_dsp_write(dsp, AUTO_DMA_16B_DA_FIFO);
         sb_dsp_write(dsp, dsp->playing.mode);
-        sb_dsp_write(dsp, play_size & 0xff);
-        sb_dsp_write(dsp, play_size >> 8);
+        sb_dsp_write(dsp, (play_size - 1) & 0xff);
+        sb_dsp_write(dsp, (play_size - 1) >> 8);
 
         return EOK;