Changeset 95d45482 in mainline


Ignore:
Timestamp:
2018-11-09T22:29:12Z (5 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
be6e37a
Parents:
436a0a5
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-08 23:08:28)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-11-09 22:29:12)
Message:

XXX to NOTE

Files:
13 edited

Legend:

Unmodified
Added
Removed

  • boot/Makefile.common

    r436a0a5 r95d45482  
    5858ifeq ($(PRECHECK),y)
    5959        JOBFILE = $(TOOLS_PATH)/jobfile.py
    60         # XXX: Do not change the order of arguments.
     60        # NOTE: You must not change the order of arguments.
    6161        CC_JOB = $(JOBFILE) $(JOB) $(CC) $< -o $@
    6262else

  • kernel/Makefile

    r436a0a5 r95d45482  
    6565ifeq ($(PRECHECK),y)
    6666        JOBFILE = $(ROOT_PATH)/tools/jobfile.py
    67         # XXX: Do not change the order of arguments.
     67        # NOTE: You must not change the order of arguments.
    6868        CC_JOB = $(JOBFILE) $(JOB) $(CC) $< -o $@
    6969else

  • kernel/arch/amd64/_link.ld.in

    r436a0a5 r95d45482  
    3333                *(COMMON);      /* global variables */
    3434
    35                 /* XXX: bss can't be omitted from the ELF image. */
     35                /* bss can't be omitted from the ELF image. */
    3636                *(.bss);        /* uninitialized static variables */
    3737

  • kernel/arch/arm32/include/arch/context_struct.h

    r436a0a5 r95d45482  
    3232#include <typedefs.h>
    3333
    34 // XXX: This struct must match assembly code in src/context.S
     34// NOTE: This struct must match assembly code in src/context.S
    3535
    3636/*

  • kernel/arch/arm32/include/arch/istate_struct.h

    r436a0a5 r95d45482  
    3232#include <stdint.h>
    3333
    34 // XXX: Must match assembly code in src/exc_handler.S
     34// NOTE: Must match assembly code in src/exc_handler.S
    3535
    3636typedef struct istate {

  • kernel/arch/ia32/_link.ld.in

    r436a0a5 r95d45482  
    3232                *(COMMON);              /* global variables */
    3333
    34                 /* XXX: bss can't be omitted from the ELF image. */
     34                /* bss can't be omitted from the ELF image. */
    3535                *(.bss);                /* uninitialized static variables */
    3636

  • kernel/arch/ppc32/src/exception.S

    r436a0a5 r95d45482  
    126126.endm
    127127
    128 // XXX: K_UNMAPPED_TEXT_START section starts at 0x100,
     128// NOTE: K_UNMAPPED_TEXT_START section starts at 0x100,
    129129// so all the following .org directives are relative to that.
    130130#define ABSOLUTE(x) ((x) - 0x100)

  • kernel/generic/include/lib/refcount.h

    r436a0a5 r95d45482  
    6464static inline void refcount_up(atomic_refcount_t *rc)
    6565{
    66         // XXX: We can use relaxed operation because acquiring a reference
    67         //      implies no ordering relationships. A reference-counted object
    68         //      still needs to be synchronized independently of the refcount.
     66        // NOTE: We can use relaxed operation because acquiring a reference
     67        //       implies no ordering relationships. A reference-counted object
     68        //       still needs to be synchronized independently of the refcount.
    6969
    7070        int old = atomic_fetch_add_explicit(&rc->__cnt, 1,
    … …  
    9696static inline bool refcount_down(atomic_refcount_t *rc)
    9797{
    98         // XXX: The decrementers don't need to synchronize with each other,
    99         //      but they do need to synchronize with the one doing deallocation.
     98        // NOTE: The decrementers don't need to synchronize with each other,
     99        //       but they do need to synchronize with the one doing deallocation.
    100100        int old = atomic_fetch_sub_explicit(&rc->__cnt, 1,
    101101            memory_order_release);
    … …  
    104104
    105105        if (old == 0) {
    106                 // XXX: We are holding the last reference, so we must now
    107                 //      synchronize with all the other decrementers.
     106                // NOTE: We are holding the last reference, so we must now
     107                //       synchronize with all the other decrementers.
    108108
    109109                int val = atomic_load_explicit(&rc->__cnt,

  • kernel/generic/src/cpu/cpu.c

    r436a0a5 r95d45482  
    7171                memsetb(cpus, sizeof(cpu_t) * config.cpu_count, 0);
    7272
    73                 // XXX: All kernel stacks must be aligned to STACK_SIZE,
    74                 //      see get_stack_base().
     73                // NOTE: All kernel stacks must be aligned to STACK_SIZE,
     74                //       see get_stack_base().
    7575                size_t i;
    7676                for (i = 0; i < config.cpu_count; i++) {

  • kernel/generic/src/main/main.c

    r436a0a5 r95d45482  
    171171            ALIGN_UP((uintptr_t) kdata_end - config.base, PAGE_SIZE);
    172172
    173         // XXX: All kernel stacks must be aligned to STACK_SIZE,
    174         //      see get_stack_base().
     173        // NOTE: All kernel stacks must be aligned to STACK_SIZE,
     174        //       see get_stack_base().
    175175
    176176        /* Place the stack after the kernel, init and ballocs. */

  • kernel/generic/src/proc/thread.c

    r436a0a5 r95d45482  
    190190        kmflags &= ~FRAME_HIGHMEM;
    191191
    192         // XXX: All kernel stacks must be aligned to STACK_SIZE,
    193         //      see get_stack_base().
     192        // NOTE: All kernel stacks must be aligned to STACK_SIZE,
     193        //       see get_stack_base().
    194194
    195195        uintptr_t stack_phys =

  • kernel/generic/src/synch/spinlock.c

    r436a0a5 r95d45482  
    161161bool spinlock_locked(spinlock_t *lock)
    162162{
    163         // XXX: Atomic flag doesn't support simple atomic read (by design),
    164         //      so instead we test_and_set and then clear if necessary.
    165         //      This function is only used inside assert, so we don't need
    166         //      any preemption_disable/enable here.
     163        // NOTE: Atomic flag doesn't support simple atomic read (by design),
     164        //       so instead we test_and_set and then clear if necessary.
     165        //       This function is only used inside assert, so we don't need
     166        //       any preemption_disable/enable here.
    167167
    168168        bool ret = atomic_flag_test_and_set_explicit(&lock->flag, memory_order_relaxed);

  • uspace/Makefile.common

    r436a0a5 r95d45482  
    275275ifeq ($(PRECHECK),y)
    276276        JOBFILE = $(LIBC_PREFIX)/../../../tools/jobfile.py
    277         # XXX: Do not change the order of arguments.
     277        # NOTE: You must not change the order of arguments.
    278278        CC_JOB = $(JOBFILE) $(JOB) $(CC) $< -o $@
    279279        CXX_JOB = $(JOBFILE) $(JOB) $(CXX) $< -o $@
Note: See TracChangeset for help on using the changeset viewer.