Changeset 918e9910 in mainline for uspace/srv/net/checksum.c

Timestamp:

2010-02-12T13:50:47Z (14 years ago)

Author:

Lukas Mejdrech <lukasmejdrech@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

827d73f

Parents:

4be390b

Message:

• zero IP checksum flip fix

File:

• uspace/srv/net/checksum.c (modified) (2 diffs)

uspace/srv/net/checksum.c

@@ -46 +46 @@
  */
 #define CRC_DIVIDER_LE  0xEDB88320
-
-/** IP checksum value for computed zero checksum.
- *  Zero is returned as 0xFFFF (not flipped)
- */
-#define IP_CHECKSUM_ZERO                        0xFFFFu
 
 uint32_t compute_crc32_le( uint32_t seed, uint8_t * data, size_t length ){
@@ -135 +130 @@
 uint16_t flip_checksum( uint16_t checksum ){
         // flip, zero is returned as 0xFFFF (not flipped)
-        return ( ~ checksum ) ? ( uint16_t ) ( ~ checksum ) : IP_CHECKSUM_ZERO;
+        checksum = ~ checksum;
+        return checksum ? checksum : IP_CHECKSUM_ZERO;
 }