Changes in uspace/lib/pcut/src/os/helenos.c [f77c1c9:8d2dd7f2] in mainline

File:

• uspace/lib/pcut/src/os/helenos.c (modified) (5 diffs)

uspace/lib/pcut/src/os/helenos.c

@@ -154 +154 @@
  * @param test Test to be run.
  */
-int pcut_run_test_forking(const char *self_path, pcut_item_t *test) {
+void pcut_run_test_forking(const char *self_path, pcut_item_t *test) {
         before_test_start(test);
 
         char tempfile_name[PCUT_TEMP_FILENAME_BUFFER_SIZE];
         snprintf(tempfile_name, PCUT_TEMP_FILENAME_BUFFER_SIZE - 1, "pcut_%lld.tmp", (unsigned long long) task_get_id());
-        int tempfile;
-        int rc = vfs_lookup_open(tempfile_name, WALK_REGULAR | WALK_MAY_CREATE, MODE_READ | MODE_WRITE, &tempfile);
-        if (rc != EOK) {
-                pcut_report_test_done(test, PCUT_OUTCOME_INTERNAL_ERROR, "Failed to create temporary file.", NULL, NULL);
-                return PCUT_OUTCOME_INTERNAL_ERROR;
+        int tempfile = vfs_lookup_open(tempfile_name, WALK_REGULAR | WALK_MAY_CREATE, MODE_READ | MODE_WRITE);
+        if (tempfile < 0) {
+                pcut_report_test_done(test, TEST_OUTCOME_ERROR, "Failed to create temporary file.", NULL, NULL);
+                return;
         }
 
@@ -175 +174 @@
         };
 
-        int status = PCUT_OUTCOME_PASS;
+        int status = TEST_OUTCOME_PASS;
 
         task_wait_t test_task_wait;
-        rc = task_spawnvf(&test_task_id, &test_task_wait, self_path, arguments,
+        int rc = task_spawnvf(&test_task_id, &test_task_wait, self_path, arguments,
             fileno(stdin), tempfile, tempfile);
         if (rc != EOK) {
-                status = PCUT_OUTCOME_INTERNAL_ERROR;
+                status = TEST_OUTCOME_ERROR;
                 goto leave_close_tempfile;
         }
@@ -199 +198 @@
         rc = task_wait(&test_task_wait, &task_exit, &task_retval);
         if (rc != EOK) {
-                status = PCUT_OUTCOME_INTERNAL_ERROR;
+                status = TEST_OUTCOME_ERROR;
                 goto leave_close_tempfile;
         }
         if (task_exit == TASK_EXIT_UNEXPECTED) {
-                status = PCUT_OUTCOME_INTERNAL_ERROR;
+                status = TEST_OUTCOME_ERROR;
         } else {
-                status = task_retval == 0 ? PCUT_OUTCOME_PASS : PCUT_OUTCOME_FAIL;
+                status = task_retval == 0 ? TEST_OUTCOME_PASS : TEST_OUTCOME_FAIL;
         }
 
@@ -214 +213 @@
 
         aoff64_t pos = 0;
-        size_t nread;
-        vfs_read(tempfile, &pos, extra_output_buffer, OUTPUT_BUFFER_SIZE, &nread);
+        vfs_read(tempfile, &pos, extra_output_buffer, OUTPUT_BUFFER_SIZE);
 
 leave_close_tempfile:
@@ -222 +220 @@
 
         pcut_report_test_done_unparsed(test, status, extra_output_buffer, OUTPUT_BUFFER_SIZE);
-
-        return status;
 }