Changeset 8cffdf5 in mainline

Timestamp:

2014-03-11T07:08:41Z (10 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b0b4592e, d52ab7b

Parents:

c60e9ee

git-author:

Agnieszka Tabaka <> (2014-03-11 07:08:41)

git-committer:

Vojtech Horky <vojtechhorky@…> (2014-03-11 07:08:41)

Message:

libgpt: random UUID conforms to RFC (thx Agnieszka Tabaka)

File:

• uspace/lib/gpt/libgpt.c (modified) (2 diffs)

uspace/lib/gpt/libgpt.c

@@ -707 +707 @@
 }
 
-/** Generate a new pseudo-random UUID
- *
- * FIXME: This UUID generator is not compliant with RFC 4122.
- *
- */
+/** Generate a new pseudo-random UUID compliant with RFC 4122 */
 void gpt_set_random_uuid(uint8_t *uuid)
 {
@@ -718 +714 @@
         for (size_t i = 0; i < 16; i++)
                 uuid[i] = random();
+
+        /* 
+         * Set version (stored in bits 4-7 of seventh byte) to 4 (random
+         * UUID) and bits 6 and 7 of ninth byte to 0 and 1 respectively -
+         * according to RFC 4122, section 4.4.
+         */
+        uuid[6] &= 0x0f;
+        uuid[6] |= (0x4 << 4);
+        uuid[8] &= 0x3f;
+        uuid[8] |= (1 << 7);
 }