Changeset 8afeb04 in mainline for uspace/lib/drv/generic/remote_usbhc.c

Timestamp:

2012-01-01T22:27:11Z (12 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

948911d

Parents:

2b621cb

Message:

libdrv,usb : Return EBADMEM on invalid pointers.

File:

• uspace/lib/drv/generic/remote_usbhc.c (modified) (8 diffs)

uspace/lib/drv/generic/remote_usbhc.c

@@ -165 +165 @@
 {
         if (!exch || !address)
-                return EINVAL;
+                return EBADMEM;
         sysarg_t new_address;
         const int ret = async_req_4_1(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
@@ -178 +178 @@
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         return async_req_3_0(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
             IPC_M_USBHC_BIND_ADDRESS, address, handle);
@@ -187 +187 @@
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         sysarg_t h;
         const int ret = async_req_2_1(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
@@ -199 +199 @@
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         return async_req_2_0(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
             IPC_M_USBHC_RELEASE_ADDRESS, address);
@@ -209 +209 @@
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         const usb_target_t target =
             {{ .address = address, .endpoint = endpoint }};
@@ -225 +225 @@
 {
         if (!exch)
-                return EINVAL;
+                return EBADMEM;
         return async_req_4_0(exch, DEV_IFACE_ID(USBHC_DEV_IFACE),
             IPC_M_USBHC_UNREGISTER_ENDPOINT, address, endpoint, direction);
@@ -234 +234 @@
     size_t *rec_size)
 {
+        if (!exch)
+                return EBADMEM;
+
         if (size == 0 && setup == 0)
                 return EOK;
 
-        if (!exch)
-                return EINVAL;
         const usb_target_t target =
             {{ .address = address, .endpoint = endpoint }};
@@ -288 +289 @@
     usb_endpoint_t endpoint, uint64_t setup, const void *data, size_t size)
 {
+        if (!exch)
+                return EBADMEM;
+
         if (size == 0 && setup == 0)
                 return EOK;
 
-        if (!exch)
-                return EINVAL;
         const usb_target_t target =
             {{ .address = address, .endpoint = endpoint }};