Fork us on GitHub Follow us on Facebook Follow us on Twitter

Ignore:
Timestamp:
2017-11-20T12:56:00Z (5 years ago)
Author:
Aearsis <Hlavaty.Ondrej@…>
Branches:
lfn, master, serial
Children:
d3086873
Parents:
ff14aede
git-author:
Aearsis <Hlavaty.Ondrej@…> (2017-11-20 12:55:58)
git-committer:
Aearsis <Hlavaty.Ondrej@…> (2017-11-20 12:56:00)
Message:

usbhost: endpoints do not have speed on their own

This information was redundant, and the fact it was never set proves it
should be removed because it is source of errors.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • uspace/drv/bus/usb/ehci/hw_struct/queue_head.c

    rff14aede r888238e9  
    6464                return;
    6565        }
    66         assert(ep->speed < ARRAY_SIZE(speed));
     66        assert(ep->device->speed < ARRAY_SIZE(speed));
    6767        EHCI_MEM32_WR(instance->ep_char,
    6868            QH_EP_CHAR_ADDR_SET(ep->device->address) |
    6969            QH_EP_CHAR_EP_SET(ep->endpoint) |
    70             speed[ep->speed] |
     70            speed[ep->device->speed] |
    7171            QH_EP_CHAR_MAX_LENGTH_SET(ep->max_packet_size)
    7272        );
    7373        if (ep->transfer_type == USB_TRANSFER_CONTROL) {
    74                 if (ep->speed != USB_SPEED_HIGH)
     74                if (ep->device->speed != USB_SPEED_HIGH)
    7575                        EHCI_MEM32_SET(instance->ep_char, QH_EP_CHAR_C_FLAG);
    7676                /* Let BULK and INT use queue head managed toggle,
     
    8080        uint32_t ep_cap = QH_EP_CAP_C_MASK_SET(3 << 2) |
    8181                    QH_EP_CAP_MULTI_SET(ep->packets);
    82         if (ep->speed != USB_SPEED_HIGH) {
     82        if (ep->device->speed != USB_SPEED_HIGH) {
    8383                ep_cap |=
    8484                    QH_EP_CAP_TT_PORT_SET(ep->device->tt.port) |
Note: See TracChangeset for help on using the changeset viewer.