Changeset 8562724 in mainline

Timestamp:

2012-01-12T08:16:42Z (12 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d545d03

Parents:

30d4706

Message:

remcons: minor refactoring

Location:

uspace/srv/hid/remcons

Files:

• remcons.c (modified) (1 diff)
• user.c (modified) (2 diffs)
• user.h (modified) (1 diff)

uspace/srv/hid/remcons/remcons.c

@@ -254 +254 @@
 
         /* Announce user disconnection. */
-        fibril_mutex_lock(&user->refcount_mutex);
-        user->locsrv_connection_count--;
-        fibril_condvar_signal(&user->refcount_cv);
-        fibril_mutex_unlock(&user->refcount_mutex);
+        telnet_user_notify_client_disconnected(user);
 }
 

uspace/srv/hid/remcons/user.c

@@ -53 +53 @@
 #include <io/console.h>
 #include <inttypes.h>
+#include <assert.h>
 #include "user.h"
 
@@ -146 +147 @@
 }
 
+void telnet_user_notify_client_disconnected(telnet_user_t *user)
+{
+        fibril_mutex_lock(&user->refcount_mutex);
+        assert(user->locsrv_connection_count > 0);
+        user->locsrv_connection_count--;
+        fibril_condvar_signal(&user->refcount_cv);
+        fibril_mutex_unlock(&user->refcount_mutex);
+}
 
 

uspace/srv/hid/remcons/user.h

@@ -67 +67 @@
 void telnet_user_destroy(telnet_user_t *user);
 telnet_user_t *telnet_user_get_for_client_connection(service_id_t id);
+void telnet_user_notify_client_disconnected(telnet_user_t *user);
 
 #endif