Changeset 84a04dd in mainline for uspace/drv/usbhub/usbhub.c

Timestamp:

2011-04-18T20:21:58Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

44b1674, c7d19d84, da1dd48, e3f1987

Parents:

8595577b (diff), 4125b7d (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

C-style, more IPC hiding (#196, #187)

Removed obsoleted usb_pipe_start_session() and
usb_pipe_end_session().

Printf-like functions produces warning with bad modifiers.

usb_pipe_start_long_transfer() is of type void to save-up checks
that would rarely fail (failure is received upon trying to communicate
over such pipe).

File:

• uspace/drv/usbhub/usbhub.c (modified) (4 diffs)

uspace/drv/usbhub/usbhub.c

@@ -264 +264 @@
                                     port+1, USB_HUB_FEATURE_PORT_POWER);
                                 if (opResult != EOK) {
-                                        usb_log_error("cannot power on port %d;  %d\n",
-                                            port+1, opResult);
+                                        usb_log_error("cannot power on port %zu: %s.\n",
+                                            port+1, str_error(opResult));
                                 }
                         }
@@ -273 +273 @@
                             USB_HUB_FEATURE_C_HUB_LOCAL_POWER);
                         if (opResult != EOK) {
-                                usb_log_error("cannot power hub;  %d\n",
-                                  opResult);
+                                usb_log_error("cannot power hub: %s\n",
+                                    str_error(opResult));
                         }
                 }
@@ -362 +362 @@
         }
 
-        usb_log_info("Controlling hub `%s' (%d ports).\n",
+        usb_log_info("Controlling hub `%s' (%zu ports).\n",
             hub_info->usb_device->ddf_dev->name, hub_info->port_count);
         return EOK;
@@ -430 +430 @@
                             port, USB_HUB_FEATURE_PORT_POWER);
                         if (opResult != EOK) {
-                                usb_log_error("cannot power on port %d;  %d\n",
-                                    port, opResult);
+                                usb_log_error("Cannot power on port %zu: %s.\n",
+                                    port, str_error(opResult));
                         }
                 }