Changeset 84a04dd in mainline for uspace/drv/usbhub/ports.c

Timestamp:

2011-04-18T20:21:58Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

44b1674, c7d19d84, da1dd48, e3f1987

Parents:

8595577b (diff), 4125b7d (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

C-style, more IPC hiding (#196, #187)

Removed obsoleted usb_pipe_start_session() and
usb_pipe_end_session().

Printf-like functions produces warning with bad modifiers.

usb_pipe_start_long_transfer() is of type void to save-up checks
that would rarely fail (failure is received upon trying to communicate
over such pipe).

File:

• uspace/drv/usbhub/ports.c (modified) (6 diffs)

uspace/drv/usbhub/ports.c

@@ -83 +83 @@
 void usb_hub_process_interrupt(usb_hub_info_t * hub,
         uint16_t port) {
-        usb_log_debug("interrupt at port %d\n", port);
+        usb_log_debug("interrupt at port %zu\n", (size_t) port);
         //determine type of change
         //usb_pipe_t *pipe = hub->control_pipe;
@@ -93 +93 @@
         if (opResult != EOK) {
                 usb_log_error("Failed to get port %zu status: %s.\n",
-                    port, str_error(opResult));
+                    (size_t) port, str_error(opResult));
                 return;
         }
@@ -100 +100 @@
                 bool device_connected = usb_port_is_status(status,
                     USB_HUB_FEATURE_PORT_CONNECTION);
-                usb_log_debug("Connection change on port %zu: %s.\n", port,
+                usb_log_debug("Connection change on port %zu: %s.\n",
+                    (size_t) port,
                     device_connected ? "device attached" : "device removed");
 
@@ -109 +110 @@
                                 usb_log_error(
                                     "Cannot handle change on port %zu: %s.\n",
-                                    str_error(opResult));
+                                    (size_t) port, str_error(opResult));
                         }
                 } else {
@@ -210 +211 @@
 static void usb_hub_port_reset_completed(usb_hub_info_t * hub,
         uint16_t port, uint32_t status){
-        usb_log_debug("Port %zu reset complete.\n", port);
+        usb_log_debug("Port %zu reset complete.\n", (size_t) port);
         if (usb_port_is_status(status, USB_HUB_FEATURE_PORT_ENABLE)) {
                 /* Finalize device adding. */
@@ -222 +223 @@
                 usb_log_warning(
                     "Port %zu reset complete but port not enabled.\n",
-                    port);
+                    (size_t) port);
         }
 }