Changeset 816f5f4 in mainline for uspace/lib/usbdev/src/pipes.c

Timestamp:

2017-10-15T16:55:48Z (7 years ago)

Author:

Michal Staruch <salmelu@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

9b2f69e

Parents:

2770b66

Message:

Remote USB (async) sending structures

remote_usb_register_endpoint is now sending a whole new structure, instead of 5 numeric arguments pulled out of structure.
This allows future extensibility for the structure as well as a working code to be used for other remote async calls.

File:

• uspace/lib/usbdev/src/pipes.c (modified) (11 diffs)

uspace/lib/usbdev/src/pipes.c

@@ -51 +51 @@
         assert(pipe != NULL);
 
-        if (!pipe->auto_reset_halt || (pipe->endpoint_no != 0)) {
+        if (!pipe->auto_reset_halt || (pipe->desc.endpoint_no != 0)) {
                 return;
         }
@@ -88 +88 @@
         }
 
-        if ((pipe->direction != USB_DIRECTION_BOTH)
-            || (pipe->transfer_type != USB_TRANSFER_CONTROL)) {
+        if ((pipe->desc.direction != USB_DIRECTION_BOTH)
+            || (pipe->desc.transfer_type != USB_TRANSFER_CONTROL)) {
                 return EBADF;
         }
@@ -98 +98 @@
         async_exch_t *exch = async_exchange_begin(pipe->bus_session);
         size_t act_size = 0;
-        const int rc = usb_read(exch, pipe->endpoint_no, setup_packet, buffer,
+        const int rc = usb_read(exch, pipe->desc.endpoint_no, setup_packet, buffer,
             buffer_size, &act_size);
         async_exchange_end(exch);
@@ -142 +142 @@
         }
 
-        if ((pipe->direction != USB_DIRECTION_BOTH)
-            || (pipe->transfer_type != USB_TRANSFER_CONTROL)) {
+        if ((pipe->desc.direction != USB_DIRECTION_BOTH)
+            || (pipe->desc.transfer_type != USB_TRANSFER_CONTROL)) {
                 return EBADF;
         }
@@ -152 +152 @@
         async_exch_t *exch = async_exchange_begin(pipe->bus_session);
         const int rc = usb_write(exch,
-            pipe->endpoint_no, setup_packet, buffer, buffer_size);
+            pipe->desc.endpoint_no, setup_packet, buffer, buffer_size);
         async_exchange_end(exch);
 
@@ -183 +183 @@
         }
 
-        if (pipe->direction != USB_DIRECTION_IN) {
-                return EBADF;
-        }
-
-        if (pipe->transfer_type == USB_TRANSFER_CONTROL) {
+        if (pipe->desc.direction != USB_DIRECTION_IN) {
+                return EBADF;
+        }
+
+        if (pipe->desc.transfer_type == USB_TRANSFER_CONTROL) {
                 return EBADF;
         }
 
         /* Isochronous transfer are not supported (yet) */
-        if (pipe->transfer_type != USB_TRANSFER_INTERRUPT &&
-            pipe->transfer_type != USB_TRANSFER_BULK)
+        if (pipe->desc.transfer_type != USB_TRANSFER_INTERRUPT &&
+            pipe->desc.transfer_type != USB_TRANSFER_BULK)
             return ENOTSUP;
 
@@ -199 +199 @@
         size_t act_size = 0;
         const int rc =
-            usb_read(exch, pipe->endpoint_no, 0, buffer, size, &act_size);
+            usb_read(exch, pipe->desc.endpoint_no, 0, buffer, size, &act_size);
         async_exchange_end(exch);
 
@@ -224 +224 @@
         }
 
-        if (pipe->direction != USB_DIRECTION_OUT) {
-                return EBADF;
-        }
-
-        if (pipe->transfer_type == USB_TRANSFER_CONTROL) {
+        if (pipe->desc.direction != USB_DIRECTION_OUT) {
+                return EBADF;
+        }
+
+        if (pipe->desc.transfer_type == USB_TRANSFER_CONTROL) {
                 return EBADF;
         }
 
         /* Isochronous transfer are not supported (yet) */
-        if (pipe->transfer_type != USB_TRANSFER_INTERRUPT &&
-            pipe->transfer_type != USB_TRANSFER_BULK)
+        if (pipe->desc.transfer_type != USB_TRANSFER_INTERRUPT &&
+            pipe->desc.transfer_type != USB_TRANSFER_BULK)
             return ENOTSUP;
 
         async_exch_t *exch = async_exchange_begin(pipe->bus_session);
-        const int rc = usb_write(exch, pipe->endpoint_no, 0, buffer, size);
+        const int rc = usb_write(exch, pipe->desc.endpoint_no, 0, buffer, size);
         async_exchange_end(exch);
         return rc;
@@ -258 +258 @@
         assert(pipe);
 
-        pipe->endpoint_no = endpoint_no;
-        pipe->transfer_type = transfer_type;
-        pipe->packets = packets;
-        pipe->max_packet_size = max_packet_size;
-        pipe->direction = direction;
+        pipe->desc.endpoint_no = endpoint_no;
+        pipe->desc.transfer_type = transfer_type;
+        pipe->desc.packets = packets;
+        pipe->desc.max_packet_size = max_packet_size;
+        pipe->desc.direction = direction;
         pipe->auto_reset_halt = false;
         pipe->bus_session = bus_session;
@@ -297 +297 @@
         assert(pipe);
         assert(pipe->bus_session);
+
+        pipe->desc.usb2.polling_interval = interval;
         async_exch_t *exch = async_exchange_begin(pipe->bus_session);
         if (!exch)
                 return ENOMEM;
-        const int ret = usb_register_endpoint(exch, pipe->endpoint_no,
-            pipe->transfer_type, pipe->direction, pipe->max_packet_size,
-            pipe->packets, interval);
+
+        const int ret = usb_register_endpoint(exch, &pipe->desc);
+
         async_exchange_end(exch);
         return ret;
@@ -319 +321 @@
         if (!exch)
                 return ENOMEM;
-        const int ret = usb_unregister_endpoint(exch, pipe->endpoint_no,
-            pipe->direction);
+
+        const int ret = usb_unregister_endpoint(exch, &pipe->desc);
+
         async_exchange_end(exch);
         return ret;