Changeset 7ec3c56 in mainline for kernel/generic/src/mm/slab.c

Timestamp:

2015-06-04T14:20:19Z (9 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

87a2f9b

Parents:

315b7e3

Message:

define a contract that the slab cache size needs to be non-zero
zero size would cause a division by zero in comp_objects()
(detected by Coverity as CID 10260)

File:

• kernel/generic/src/mm/slab.c (modified) (2 diffs)

kernel/generic/src/mm/slab.c

@@ -610 +610 @@
     unsigned int kmflag), size_t (*destructor)(void *obj), unsigned int flags)
 {
+        ASSERT(size > 0);
+        
         memsetb(cache, sizeof(*cache), 0);
         cache->name = name;
@@ -888 +890 @@
         /* Initialize magazine cache */
         _slab_cache_create(&mag_cache, "slab_magazine_t",
-            sizeof(slab_magazine_t) + SLAB_MAG_SIZE * sizeof(void*),
+            sizeof(slab_magazine_t) + SLAB_MAG_SIZE * sizeof(void *),
             sizeof(uintptr_t), NULL, NULL, SLAB_CACHE_NOMAGAZINE |
             SLAB_CACHE_SLINSIDE);