Changeset 7bdedb5 in mainline

Timestamp:

2018-12-21T16:35:43Z (5 years ago)

Author:

Maurizio Lombardi <mlombard@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a49c39c8

Parents:

4a33845

Message:

libext4: fix double free in case ext4_filesystem_open() fails.

I hit an assert in free() when opening an invalid ext4 filesystem,
this was due to a bug in ext4_filesystem_open().
In case of error, it called ext4_filesystem_fini() against an
uninitialized filesystem instance.

File:

• uspace/lib/ext4/src/filesystem.c (modified) (3 diffs)

uspace/lib/ext4/src/filesystem.c

@@ -421 +421 @@
     enum cache_mode cmode, aoff64_t *size, ext4_filesystem_t **rfs)
 {
+        int fs_inited = 0;
         ext4_filesystem_t *fs = NULL;
         fs_node_t *root_node = NULL;
@@ -437 +438 @@
         if (rc != EOK)
                 goto error;
+
+        fs_inited = 1;
 
         /* Read root node */
@@ -463 +466 @@
                 ext4_node_put(root_node);
 
-        if (fs != NULL) {
+        if (fs_inited)
                 ext4_filesystem_fini(fs);
-                free(fs);
-        }
-
+        free(fs);
         return rc;
 }