Changeset 79ae36dd in mainline for uspace/srv/hw/irc/i8259/i8259.c

Timestamp:

2011-06-08T19:01:55Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0eff68e

Parents:

764d71e

Message:

new async framework with integrated exchange tracking

• strict isolation between low-level IPC and high-level async framework with integrated exchange tracking
  • each IPC connection is represented by an async_sess_t structure
  • each IPC exchange is represented by an async_exch_t structure
  • exchange management is either based on atomic messages (EXCHANGE_ATOMIC), locking (EXCHANGE_SERIALIZE) or connection cloning (EXCHANGE_CLONE)
• async_obsolete: temporary compatibility layer to keep old async clients working (several pieces of code are currently broken, but only non-essential functionality)
• IPC_M_PHONE_HANGUP is now method no. 0 (for elegant boolean evaluation)
• IPC_M_DEBUG_ALL has been renamed to IPC_M_DEBUG
• IPC_M_PING has been removed (VFS protocol now has VFS_IN_PING)
• console routines in libc have been rewritten for better abstraction
• additional use for libc-private header files (FILE structure opaque to the client)
• various cstyle changes (typos, indentation, missing externs in header files, improved comments, etc.)

File:

• uspace/srv/hw/irc/i8259/i8259.c (modified) (6 diffs)

uspace/srv/hw/irc/i8259/i8259.c

@@ -38 +38 @@
 #include <ipc/services.h>
 #include <ipc/irc.h>
-#include <ipc/ns.h>
+#include <ns.h>
 #include <sysinfo.h>
 #include <as.h>
@@ -113 +113 @@
                 callid = async_get_call(&call);
                 
+                if (!IPC_GET_IMETHOD(call)) {
+                        /* The other side has hung up. */
+                        async_answer_0(callid, EOK);
+                        return;
+                }
+                
                 switch (IPC_GET_IMETHOD(call)) {
                 case IRC_ENABLE_INTERRUPT:
@@ -121 +127 @@
                         async_answer_0(callid, EOK);
                         break;
-                case IPC_M_PHONE_HUNGUP:
-                        /* The other side has hung up. */
-                        async_answer_0(callid, EOK);
-                        return;
                 default:
                         async_answer_0(callid, EINVAL);
@@ -140 +142 @@
         
         if ((sysinfo_get_value("i8259", &i8259) != EOK) || (!i8259)) {
-                printf(NAME ": No i8259 found\n");
+                printf("%s: No i8259 found\n", NAME);
                 return false;
         }
@@ -148 +150 @@
             (pio_enable((void *) IO_RANGE1_START, IO_RANGE1_SIZE,
             (void **) &io_range1) != EOK)) {
-                printf(NAME ": i8259 not accessible\n");
+                printf("%s: i8259 not accessible\n", NAME);
                 return false;
         }
@@ -160 +162 @@
 int main(int argc, char **argv)
 {
-        printf(NAME ": HelenOS i8259 driver\n");
+        printf("%s: HelenOS i8259 driver\n", NAME);
         
         if (!i8259_init())
                 return -1;
         
-        printf(NAME ": Accepting connections\n");
+        printf("%s: Accepting connections\n", NAME);
+        task_retval(0);
         async_manager();