Changeset 79ae36dd in mainline for uspace/srv/hid/kbd/port/adb.c

Timestamp:

2011-06-08T19:01:55Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0eff68e

Parents:

764d71e

Message:

new async framework with integrated exchange tracking

• strict isolation between low-level IPC and high-level async framework with integrated exchange tracking
  • each IPC connection is represented by an async_sess_t structure
  • each IPC exchange is represented by an async_exch_t structure
  • exchange management is either based on atomic messages (EXCHANGE_ATOMIC), locking (EXCHANGE_SERIALIZE) or connection cloning (EXCHANGE_CLONE)
• async_obsolete: temporary compatibility layer to keep old async clients working (several pieces of code are currently broken, but only non-essential functionality)
• IPC_M_PHONE_HANGUP is now method no. 0 (for elegant boolean evaluation)
• IPC_M_DEBUG_ALL has been renamed to IPC_M_DEBUG
• IPC_M_PING has been removed (VFS protocol now has VFS_IN_PING)
• console routines in libc have been rewritten for better abstraction
• additional use for libc-private header files (FILE structure opaque to the client)
• various cstyle changes (typos, indentation, missing externs in header files, improved comments, etc.)

File:

• uspace/srv/hid/kbd/port/adb.c (modified) (5 diffs)

uspace/srv/hid/kbd/port/adb.c

@@ -30 +30 @@
  * @ingroup kbd
  * @{
- */ 
+ */
 /** @file
  * @brief ADB keyboard port driver.
@@ -37 +37 @@
 #include <ipc/adb.h>
 #include <async.h>
+#include <async_obsolete.h>
 #include <kbd_port.h>
 #include <kbd.h>
@@ -42 +43 @@
 #include <fcntl.h>
 #include <errno.h>
+#include <devmap.h>
+#include <devmap_obsolete.h>
 
 static void kbd_port_events(ipc_callid_t iid, ipc_call_t *icall);
@@ -52 +55 @@
 int kbd_port_init(void)
 {
-        const char *input = "/dev/adb/kbd";
-        int input_fd;
-
-        printf(NAME ": open %s\n", input);
-
-        input_fd = open(input, O_RDONLY);
-        if (input_fd < 0) {
-                printf(NAME ": Failed opening %s (%d)\n", input, input_fd);
-                return false;
+        const char *dev = "adb/kbd";
+        devmap_handle_t handle;
+        
+        int rc = devmap_device_get_handle(dev, &handle, 0);
+        if (rc == EOK) {
+                dev_phone = devmap_obsolete_device_connect(handle, 0);
+                if (dev_phone < 0) {
+                        printf("%s: Failed to connect to device\n", NAME);
+                        return dev_phone;
+                }
+        } else
+                return rc;
+        
+        /* NB: The callback connection is slotted for removal */
+        rc = async_obsolete_connect_to_me(dev_phone, 0, 0, 0, kbd_port_events);
+        if (rc != EOK) {
+                printf(NAME ": Failed to create callback from device\n");
+                return rc;
         }
-
-        dev_phone = fd_phone(input_fd);
-        if (dev_phone < 0) {
-                printf(NAME ": Failed to connect to device\n");
-                return false;
-        }
-
-        /* NB: The callback connection is slotted for removal */
-        if (async_connect_to_me(dev_phone, 0, 0, 0, kbd_port_events) != 0) {
-                printf(NAME ": Failed to create callback from device\n");
-                return false;
-        }
-
-        return 0;
+        
+        return EOK;
 }
 
@@ -100 +100 @@
 
                 int retval;
-
-                switch (IPC_GET_IMETHOD(call)) {
-                case IPC_M_PHONE_HUNGUP:
+                
+                if (!IPC_GET_IMETHOD(call)) {
                         /* TODO: Handle hangup */
                         return;
+                }
+                
+                switch (IPC_GET_IMETHOD(call)) {
                 case ADB_REG_NOTIF:
                         adb_kbd_reg0_data(IPC_GET_ARG1(call));