Changeset 79ae36dd in mainline for uspace/app/taskdump/taskdump.c

Timestamp:

2011-06-08T19:01:55Z (13 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0eff68e

Parents:

764d71e

Message:

new async framework with integrated exchange tracking

• strict isolation between low-level IPC and high-level async framework with integrated exchange tracking
  • each IPC connection is represented by an async_sess_t structure
  • each IPC exchange is represented by an async_exch_t structure
  • exchange management is either based on atomic messages (EXCHANGE_ATOMIC), locking (EXCHANGE_SERIALIZE) or connection cloning (EXCHANGE_CLONE)
• async_obsolete: temporary compatibility layer to keep old async clients working (several pieces of code are currently broken, but only non-essential functionality)
• IPC_M_PHONE_HANGUP is now method no. 0 (for elegant boolean evaluation)
• IPC_M_DEBUG_ALL has been renamed to IPC_M_DEBUG
• IPC_M_PING has been removed (VFS protocol now has VFS_IN_PING)
• console routines in libc have been rewritten for better abstraction
• additional use for libc-private header files (FILE structure opaque to the client)
• various cstyle changes (typos, indentation, missing externs in header files, improved comments, etc.)

File:

• uspace/app/taskdump/taskdump.c (modified) (12 diffs)

uspace/app/taskdump/taskdump.c

@@ -54 +54 @@
 #define LINE_BYTES 16
 
-static int phoneid;
+static async_sess_t *sess;
 static task_id_t task_id;
 static bool write_core_file;
@@ -104 +104 @@
                 printf("Failed dumping address space areas.\n");
 
-        udebug_end(phoneid);
-        async_hangup(phoneid);
+        udebug_end(sess);
+        async_hangup(sess);
 
         return 0;
@@ -112 +112 @@
 static int connect_task(task_id_t task_id)
 {
-        int rc;
-
-        rc = async_connect_kbox(task_id);
-
-        if (rc == ENOTSUP) {
-                printf("You do not have userspace debugging support "
-                    "compiled in the kernel.\n");
-                printf("Compile kernel with 'Support for userspace debuggers' "
-                    "(CONFIG_UDEBUG) enabled.\n");
-                return rc;
-        }
-
-        if (rc < 0) {
+        async_sess_t *ksess = async_connect_kbox(task_id);
+        
+        if (!ksess) {
+                if (errno == ENOTSUP) {
+                        printf("You do not have userspace debugging support "
+                            "compiled in the kernel.\n");
+                        printf("Compile kernel with 'Support for userspace debuggers' "
+                            "(CONFIG_UDEBUG) enabled.\n");
+                        return errno;
+                }
+                
                 printf("Error connecting\n");
-                printf("async_connect_kbox(%" PRIu64 ") -> %d ", task_id, rc);
-                return rc;
-        }
-
-        phoneid = rc;
-
-        rc = udebug_begin(phoneid);
+                printf("async_connect_kbox(%" PRIu64 ") -> %d ", task_id, errno);
+                return errno;
+        }
+        
+        int rc = udebug_begin(ksess);
         if (rc < 0) {
                 printf("udebug_begin() -> %d\n", rc);
                 return rc;
         }
-
+        
+        sess = ksess;
         return 0;
 }
@@ -213 +210 @@
 
         /* TODO: See why NULL does not work. */
-        rc = udebug_thread_read(phoneid, &dummy_buf, 0, &copied, &needed);
+        rc = udebug_thread_read(sess, &dummy_buf, 0, &copied, &needed);
         if (rc < 0) {
                 printf("udebug_thread_read() -> %d\n", rc);
@@ -227 +224 @@
         thash_buf = malloc(buf_size);
 
-        rc = udebug_thread_read(phoneid, thash_buf, buf_size, &copied, &needed);
+        rc = udebug_thread_read(sess, thash_buf, buf_size, &copied, &needed);
         if (rc < 0) {
                 printf("udebug_thread_read() -> %d\n", rc);
@@ -262 +259 @@
         int rc;
 
-        rc = udebug_areas_read(phoneid, &dummy_buf, 0, &copied, &needed);
+        rc = udebug_areas_read(sess, &dummy_buf, 0, &copied, &needed);
         if (rc < 0) {
                 printf("udebug_areas_read() -> %d\n", rc);
@@ -271 +268 @@
         ainfo_buf = malloc(buf_size);
 
-        rc = udebug_areas_read(phoneid, ainfo_buf, buf_size, &copied, &needed);
+        rc = udebug_areas_read(sess, ainfo_buf, buf_size, &copied, &needed);
         if (rc < 0) {
                 printf("udebug_areas_read() -> %d\n", rc);
@@ -296 +293 @@
         if (write_core_file) {
                 printf("Writing core file '%s'\n", core_file_name);
-                rc = elf_core_save(core_file_name, ainfo_buf, n_areas, phoneid);
+                rc = elf_core_save(core_file_name, ainfo_buf, n_areas, sess);
                 if (rc != EOK) {
                         printf("Failed writing core file.\n");
@@ -316 +313 @@
         int rc;
 
-        rc = udebug_regs_read(phoneid, thash, &istate);
+        rc = udebug_regs_read(sess, thash, &istate);
         if (rc < 0) {
                 printf("Failed reading registers (%d).\n", rc);
@@ -359 +356 @@
         (void) arg;
 
-        rc = udebug_mem_read(phoneid, &data, addr, sizeof(data));
+        rc = udebug_mem_read(sess, &data, addr, sizeof(data));
         if (rc < 0) {
                 printf("Warning: udebug_mem_read() failed.\n");
@@ -430 +427 @@
         int rc;
 
-        rc = udebug_name_read(phoneid, &dummy_buf, 0, &copied, &needed);
+        rc = udebug_name_read(sess, &dummy_buf, 0, &copied, &needed);
         if (rc < 0)
                 return NULL;
@@ -436 +433 @@
         name_size = needed;
         name = malloc(name_size + 1);
-        rc = udebug_name_read(phoneid, name, name_size, &copied, &needed);
+        rc = udebug_name_read(sess, name, name_size, &copied, &needed);
         if (rc < 0) {
                 free(name);