Changeset 798105ca in mainline for uspace/srv/net/tcp/sock.c

Timestamp:

2012-08-05T12:54:44Z (12 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

7cd9b02

Parents:

d4112ba

Message:

tcp_sock_recv_fibril() needs to handle situation when sock_core goes away before TCP signals end of connection.

File:

• uspace/srv/net/tcp/sock.c (modified) (4 diffs)

uspace/srv/net/tcp/sock.c

@@ -779 +779 @@
         }
 
+        /* Grab recv_buffer_lock because of CV wait in tcp_sock_recv_fibril() */
+        fibril_mutex_lock(&socket->recv_buffer_lock);
+        socket->sock_core = NULL;
+        fibril_mutex_unlock(&socket->recv_buffer_lock);
+
         rc = socket_destroy(NULL, socket_id, &client->sockets, &gsock,
             tcp_free_sock_data);
@@ -839 +844 @@
         log_msg(LVL_DEBUG, "tcp_sock_recv_fibril()");
 
+        fibril_mutex_lock(&sock->recv_buffer_lock);
+
         while (true) {
                 log_msg(LVL_DEBUG, "call tcp_uc_receive()");
-                fibril_mutex_lock(&sock->recv_buffer_lock);
-                while (sock->recv_buffer_used != 0)
+                while (sock->recv_buffer_used != 0 && sock->sock_core != NULL)
                         fibril_condvar_wait(&sock->recv_buffer_cv,
                             &sock->recv_buffer_lock);
@@ -852 +858 @@
                         sock->recv_error = trc;
                         fibril_condvar_broadcast(&sock->recv_buffer_cv);
-                        fibril_mutex_unlock(&sock->recv_buffer_lock);
-                        tcp_sock_notify_data(sock->sock_core);
+                        if (sock->sock_core != NULL)
+                                tcp_sock_notify_data(sock->sock_core);
                         break;
                 }
@@ -861 +867 @@
                 sock->recv_buffer_used = data_len;
                 fibril_condvar_broadcast(&sock->recv_buffer_cv);
-                fibril_mutex_unlock(&sock->recv_buffer_lock);
-                tcp_sock_notify_data(sock->sock_core);
-        }
+                if (sock->sock_core != NULL)
+                        tcp_sock_notify_data(sock->sock_core);
+        }
+
+        fibril_mutex_unlock(&sock->recv_buffer_lock);
 
         tcp_uc_delete(sock->conn);