Changeset 7896f23 in mainline for uspace/lib/ui/src/window.c

Timestamp:

2021-09-04T08:09:38Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ab3bfc1

Parents:

3c3657c

Message:

Do not delete window→gc when destroying window

In all cases this is handled elsewhere: memory GC - destroying it
earlier, window GC - destroyed along with window later, console GC -
shared by all windows and destroyed along with UI. Deleting window→gc
here leads to a double free and heap corruption (only with server-side
rendering).

File:

• uspace/lib/ui/src/window.c (modified) (1 diff)

uspace/lib/ui/src/window.c

@@ -370 +370 @@
         if (window->bmp != NULL)
                 gfx_bitmap_destroy(window->bmp);
-        gfx_context_delete(window->gc);
         if (window->dwindow != NULL)
                 display_window_destroy(window->dwindow);